Skip to content

List sftim as en-localization reviewer#15497

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sftim:20190722_sftim_sig-docs-en-reviewers
Jul 24, 2019
Merged

List sftim as en-localization reviewer#15497
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sftim:20190722_sftim_sig-docs-en-reviewers

Conversation

@sftim
Copy link
Copy Markdown
Contributor

@sftim sftim commented Jul 22, 2019

I'd like to join the list of English language reviewers.
I'm not a native speaker (I'm from the UK 😉) but should still be able to help.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 22, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d46a7b4

https://deploy-preview-15497--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Copy Markdown
Contributor

@sftim Absolutely! You also qualify as an approver, just so you know the offer is there... 😁

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit b8efe3b into kubernetes:master Jul 24, 2019
@sftim sftim deleted the 20190722_sftim_sig-docs-en-reviewers branch August 6, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants