Skip to content

Adding the missing "true" in the garbage-collection.md to make it clear#15495

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jiachengxu:patch-4
Jul 24, 2019
Merged

Adding the missing "true" in the garbage-collection.md to make it clear#15495
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jiachengxu:patch-4

Conversation

@jiachengxu
Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 22, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5038841

https://deploy-preview-15495--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 24, 2019

Right, blockOwerDeletion is treated as false if it is nil.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 761d210 into kubernetes:master Jul 24, 2019
@jiachengxu jiachengxu deleted the patch-4 branch July 24, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants