Skip to content

Update _index.md#15494

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
jaekel:patch-1
Jul 25, 2019
Merged

Update _index.md#15494
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
jaekel:patch-1

Conversation

@jaekel
Copy link
Copy Markdown
Contributor

@jaekel jaekel commented Jul 22, 2019

Added k8s offerings by Ionos Enterprise Cloud.

Added k8s offerings by Ionos Enterprise Cloud.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @jaekel!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5226783

https://deploy-preview-15494--kubernetes-io-master-staging.netlify.com

@jaekel
Copy link
Copy Markdown
Contributor Author

jaekel commented Jul 22, 2019

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 22, 2019
@jaekel
Copy link
Copy Markdown
Contributor Author

jaekel commented Jul 22, 2019

/assign @Bradamant3

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

hello @jaekel . Thanks for the PR.
Page preview:
https://deploy-preview-15494--kubernetes-io-master-staging.netlify.com/docs/setup/
It would be great to list the English version of the Managed Kubernetes site:
https://www.ionos.de/enterprise-cloud/managed-kubernetes. Would this be possible?

@jaekel
Copy link
Copy Markdown
Contributor Author

jaekel commented Jul 24, 2019

Hello @kbhawkey.

It would be great to list the English version of the Managed Kubernetes site:
https://www.ionos.de/enterprise-cloud/managed-kubernetes. Would this be possible?

Sure! But I am confused: list it where? What should I do?

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jul 24, 2019

If you hyperlink to https://www.ionos.co.uk/enterprise-cloud/managed-kubernetes instead of to https://www.ionos.de/enterprise-cloud/managed-kubernetes then that is a page in English rather than in German.
The two pages are not equivalent but I can see why it's useful to link to the English language page.

Switched from .de domain to .com.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@jaekel
Copy link
Copy Markdown
Contributor Author

jaekel commented Jul 24, 2019

Is this better?

I changed it to ionos.com instead of ionos.de. I believe that should honor the browser language preference and default to English.

@kbhawkey
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 25, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 52ff74a into kubernetes:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants