Skip to content

Fix field in PDB#15480

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gtseres:master
Jul 24, 2019
Merged

Fix field in PDB#15480
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
gtseres:master

Conversation

@gtseres
Copy link
Copy Markdown
Contributor

@gtseres gtseres commented Jul 19, 2019

Fixing typo in website PDB documentation.

Note: I have also found the minUnavailable term here, shall I also correct it?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 19, 2019

Welcome @gtseres!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2019
@gtseres
Copy link
Copy Markdown
Contributor Author

gtseres commented Jul 19, 2019

/assign @Bradamant3

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 19, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28510a8

https://deploy-preview-15480--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

This doesn't look like a correct fix to me.

@gtseres
Copy link
Copy Markdown
Contributor Author

gtseres commented Jul 22, 2019 •
edited
Loading

@tengqm can you please elaborate on why this doesn't look correct to you? Thanks!

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 24, 2019

@gtseres Sorry, I was processing the math incorrectly.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit b4f10b3 into kubernetes:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

@Bradamant3 Bradamant3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gtseres @k8s-ci-robot @tengqm @Bradamant3