Skip to content

Line break between section and previous paragraph#15474

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
stefkiourk:patch-1
Jul 25, 2019
Merged

Line break between section and previous paragraph#15474
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
stefkiourk:patch-1

Conversation

@stefkiourk
Copy link
Copy Markdown
Contributor

@stefkiourk stefkiourk commented Jul 18, 2019

Line break between the "Kubernetes Basics Modules" and the previous paragraph, for consistency.

@stefkiourk
Line break between section and previous paragraph
b8a109e 
Line break between the "Kubernetes Basics Modules" and the previous paragraph, for consistency.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 18, 2019

Welcome @stefkiourk!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 18, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@stefkiourk
Copy link
Copy Markdown
Contributor Author

stefkiourk commented Jul 18, 2019

Contributor License Agreement (CLA) signed!

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 18, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b8a109e

https://deploy-preview-15474--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

/check-cla

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 24, 2019

@stefkiourk Please try follow instructions here to debug CLA status if you have signed it.

@stefkiourk
Copy link
Copy Markdown
Contributor Author

stefkiourk commented Jul 24, 2019

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 24, 2019
@stefkiourk
Copy link
Copy Markdown
Contributor Author

stefkiourk commented Jul 24, 2019

/assign @zparnold

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit bb9ee3d into kubernetes:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tengqm tengqm

@zparnold zparnold

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stefkiourk @k8s-ci-robot @tengqm @zparnold