Skip to content

secret.md: add an example of editing a secret#15464

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
eric-hu:patch-1
Jul 21, 2019
Merged

secret.md: add an example of editing a secret#15464
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
eric-hu:patch-1

Conversation

@eric-hu
Copy link
Copy Markdown
Contributor

@eric-hu eric-hu commented Jul 17, 2019

Hi there, my coworker mentioned that this is a task people commonly ask about in our company. Does this look like a useful addition to the docs?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 17, 2019

Welcome @eric-hu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 17, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 17, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 17, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b5e4809

https://deploy-preview-15464--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 17, 2019
sftim
sftim reviewed Jul 17, 2019
View reviewed changes
content/en/docs/concepts/configuration/secret.md
1f2d1e2e67df
```

#### Editing a Secret
Copy link
Copy Markdown
Contributor

@sftim sftim Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest: add a new, small task page about this, and link to the task page from this point in the concept page about Secrets. Also link to that task page in the Further reading.

Copy link
Copy Markdown
Contributor

@tengqm tengqm Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific PR, just adding this content looks good to me. We may need a followup PR to split a task page from this huge page.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7dae226 into kubernetes:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

+1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eric-hu @k8s-ci-robot @tengqm @sftim