kubeadm: modify the step for upgrading control plane kubelets#15452
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jul 18, 2019
Merged
kubeadm: modify the step for upgrading control plane kubelets#15452k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
When upgrading controlplane nodes, upgrading the kubelets should be done as the last step after "kubeadm upgrade" was run on all of the control plane nodes already. Also apply consistency related cleanup to sections and section names.
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2acf74c https://deploy-preview-15452--kubernetes-io-master-staging.netlify.com |
Contributor
|
LGTM, thank you @neolit123 |
fabriziopandini
approved these changes
Jul 18, 2019
Member
fabriziopandini
left a comment
There was a problem hiding this comment.
thanks @neolit123 !
/lgtm
/approve
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading control plane nodes, upgrading the kubelets should be done
as the last step after "kubeadm upgrade" was run on all of the control
plane nodes already.
Also apply consistency related cleanup to sections and section names.
xref kubernetes/kubeadm#1668
/sig cluster-lifecycle
/kind cleanup
/priority important-longterm
/cc @fabriziopandini @ereslibre
/assign @jimangel
NOTE: this is against master as it applies to 1.15.