Skip to content

Fix Prev/Next navigation buttons when viewing article#15439

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
vharsh:blog_button_fix_15438
Jul 21, 2019
Merged

Fix Prev/Next navigation buttons when viewing article#15439
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
vharsh:blog_button_fix_15438

Conversation

@vharsh
Copy link
Copy Markdown
Contributor

@vharsh vharsh commented Jul 15, 2019

Earlier both the on the left and right buttons had the text Next>> now
the left one will have the text << Prev

fixes: #15438

Signed-off-by: Harsh Vardhan harsh.vardhan@mayadata.io

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2019

Welcome @vharsh!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 15, 2019
@vharsh
Copy link
Copy Markdown
Contributor Author

vharsh commented Jul 15, 2019

/cla done

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 340d426

https://deploy-preview-15439--kubernetes-io-master-staging.netlify.com

Fix Prev/Next navigation buttons when viewing article
340d426 
Earlier both the on the left and right buttons had the text `Next>>` now
the left one will have the text `<< Prev`

fixes: #15438

Signed-off-by: Harsh Vardhan <harsh.vardhan@mayadata.io>
@vharsh
Copy link
Copy Markdown
Contributor Author

vharsh commented Jul 15, 2019

I signed it

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Jul 15, 2019 •
edited
Loading

Thanks for the PR. The changes seem fine.
Preview:
https://deploy-preview-15439--kubernetes-io-master-staging.netlify.com/blog/2019/06/24/automated-high-availability-in-kubeadm-v1.15-batteries-included-but-swappable/

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Jul 15, 2019

/check-cla

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

@vharsh would you mind check your CLA status again? Thanks.

@vharsh
Copy link
Copy Markdown
Contributor Author

vharsh commented Jul 21, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2019
@vharsh
Copy link
Copy Markdown
Contributor Author

vharsh commented Jul 21, 2019

I signed it

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 21, 2019

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit b7b8ce0 into kubernetes:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix previous/next buttons in blog

4 participants

@vharsh @k8s-ci-robot @kbhawkey @tengqm