Skip to content

Adding China unicom Case Study#15347

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
jcjesus:master
Jul 24, 2019
Merged

Adding China unicom Case Study#15347
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
jcjesus:master

Conversation

@jcjesus
Copy link
Copy Markdown
Contributor

@jcjesus jcjesus commented Jul 9, 2019

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15

For pull requests on Chinese localization, set Base Branch to release-1.14

For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@jcjesus jcjesus requested a review from femrtnz July 9, 2019 01:29
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot requested a review from stewart-yu July 9, 2019 01:30
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 9, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8f5a91f

https://deploy-preview-15347--kubernetes-io-master-staging.netlify.com

@femrtnz
Copy link
Copy Markdown
Contributor

femrtnz commented Jul 17, 2019

/assign @jcjesus

jcjesus added 4 commits July 17, 2019 20:44
Now the verb was conjugated correctly.
Added comma to separate items correctly.
Removing the br element.
Correction in verbal conjugation.
@jcjesus
Copy link
Copy Markdown
Contributor Author

jcjesus commented Jul 22, 2019

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@jcjesus: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcjesus jcjesus requested a review from femrtnz July 22, 2019 12:08
@femrtnz
Copy link
Copy Markdown
Contributor

femrtnz commented Jul 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: femrtnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@femrtnz femrtnz changed the title WIP: Adding China unicom Case Study Adding China unicom Case Study Jul 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 31cbc5e into kubernetes:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants