Add something about Tencent Cloud by yunxji · Pull Request #15298 · kubernetes/website

yunxji · 2019-07-05T04:27:46Z

Added Tencent Cloud Production Environment Solution

netlify · 2019-07-05T04:31:39Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 87649d2

https://deploy-preview-15298--kubernetes-io-master-staging.netlify.com

yunxji · 2019-07-05T04:58:31Z

/assign @jaredbhatti

…: content/en/docs/setup/production-environment/turnkey/tke.md

sftim

Informal feedback

content/en/docs/setup/production-environment/turnkey/tke.md

…m. Please select this document when merging.

yunxji · 2019-07-12T06:32:34Z

@jaredbhatti @mikedanese @brendanburns
May I know when the PR can be reviewed?

yunxji · 2019-07-12T06:55:43Z

@sftim Thank you very much for your suggestions on the document. I have already revised it according to your suggestions. Please help advance this PR review.

tengqm · 2019-07-15T03:43:48Z

I believe the text needs some improvement from native speakers. For example, the following sentence reads pretty strange to me:

For learn more about TKE in its official TKE documentation.

sftim · 2019-07-15T08:25:38Z

content/en/docs/setup/production-environment/turnkey/tencent.md

+
+ [Tencent Cloud Tencent Kubernetes Engine (TKE)](https://intl.cloud.tencent.com/product/tke) provides native Kubernetes container management services. You can deploy and manage a Kubernetes cluster with TKE in just a few steps. For detailed directions, see [Deploy Tencent Kubernetes Engine](https://intl.cloud.tencent.com/document/product/457/11741).
+
+ In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions. For learn more about TKE in its official [TKE documentation](https://intl.cloud.tencent.com/document/product/457).


Suggested change

In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions. For learn more about TKE in its official [TKE documentation](https://intl.cloud.tencent.com/document/product/457).

In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions. To learn more, see the official [TKE documentation](https://intl.cloud.tencent.com/document/product/457).

@yunxji: What do you think about moving “To learn more…” into a What's Next? section.

@sftim Excuse me, is this what you mean?

A What's Next section is like this example:
https://github.com/kubernetes/website/blame/abcee2dccd17c94376595b34cc05e56345a7f06c/content/zh/docs/concepts/workloads/pods/podpreset.md#L66

@sftim Sorry, I have some misunderstandings about your suggestion before. Now I have made the following changes based on your suggestions. Please review

@sftim

A What's Next section is like this example:
https://github.com/kubernetes/website/blame/abcee2dccd17c94376595b34cc05e56345a7f06c/content/zh/docs/concepts/workloads/pods/podpreset.md#L66

Is this the case? If this is possible, please help merge this PR.

…n-environment/turnkey/tke.md

sftim · 2019-07-16T12:25:36Z

content/en/docs/setup/production-environment/turnkey/tencent.md

+
+ [Tencent Cloud Tencent Kubernetes Engine (TKE)](https://intl.cloud.tencent.com/product/tke) provides native Kubernetes container management services. You can deploy and manage a Kubernetes cluster with TKE in just a few steps. For detailed directions, see [Deploy Tencent Kubernetes Engine](https://intl.cloud.tencent.com/document/product/457/11741).
+
+ In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions.


nit:

Suggested change

In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions.

In addition to full compatibility with the native Kubernetes API, TKE features Kubernetes plugins for Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions.

If TKE is a certified solution, mention that and simplify the text around API compatibility. At the moment this reads too much like marketing text.

@sftim Modified according to your suggestions. Please review.

@sftim What is your opinion on these changes? Is it suitable?

sftim · 2019-07-16T12:26:23Z

content/en/docs/setup/production-environment/turnkey/tencent.md

+
+ The core of Tencent Kubernetes Engine is open source and available [on GitHub](https://github.com/TencentCloud/tencentcloud-cloud-controller-manager/).
+
+ When using TKE to create a Kubernetes cluster, you can choose managed mode or independent deployment mode. In addition, you can customize the deployment as needed; for example, you can choose an existing CVM instance for cluster creation or enable Kube-proxy IPVS.


Suggested change

When using TKE to create a Kubernetes cluster, you can choose managed mode or independent deployment mode. In addition, you can customize the deployment as needed; for example, you can choose an existing CVM instance for cluster creation or enable Kube-proxy IPVS.

When using TKE to create a Kubernetes cluster, you can choose managed mode or independent deployment mode. In addition, you can customize the deployment as needed; for example, you can choose an existing CVM instance for cluster creation or enable Kube-proxy in IPVS mode.

content/en/docs/setup/production-environment/turnkey/tencent.md

sftim

This page should be Hugo markdown, with front matter similar to https://github.com/kubernetes/website/blame/5f27e08983d12a183ea99b599b9b09eeaa341bb3/content/en/docs/setup/production-environment/turnkey/aws.md#L1-L7

Does that make sense?

yunxji · 2019-07-18T08:33:29Z

This page should be Hugo markdown, with front matter similar to https://github.com/kubernetes/website/blame/5f27e08983d12a183ea99b599b9b09eeaa341bb3/content/en/docs/setup/production-environment/turnkey/aws.md#L1-L7

Does that make sense?

@sftim Thank you for reminding me. I can't say what the meaning is, but I think it's necessary. Just a little uncertain is that I don’t know if the reviewers added the right ones. What do you think?

yunxji · 2019-07-18T13:44:10Z

@sftim Can you help merge this PR?

sftim · 2019-07-18T14:04:20Z

I'm also not sure about what to put for the reviewers on this page I'm afraid.
Maybe ask for advice via SIG Docs' Slack channel?

Apart from the detail about reviewers, the PR looks good to me.

yunxji · 2019-07-19T10:02:24Z

The answer I got for this question is：

This page should be Hugo markdown, with front matter similar to https://github.com/kubernetes/website/blame/5f27e08983d12a183ea99b599b9b09eeaa341bb3/content/en/docs/setup/production-environment/turnkey/aws.md#L1-L7

Does that make sense?

@sftim
The answer I got for this question is：The tags are for Hugo to organize contents and for related Bots to trigger notifications etc.

Can I keep this content and request a merge?

yunxji

@sftim Maybe this is more appropriate. Please help merge it.

content/en/docs/setup/production-environment/turnkey/tencent.md

sftim · 2019-07-22T09:34:53Z

/lgtm

At this point @yunxji you're waiting on approval from this PR's assignee, who I think is @jaredbhatti

yunxji · 2019-07-23T02:19:18Z

Request the /approve tag. @jaredbhatti

yunxji · 2019-07-25T01:57:46Z

/assign @tengqm

yunxji · 2019-07-25T01:59:58Z

pinging @tengqm for approval

yunxji · 2019-07-26T01:50:42Z

pinging @jaredbhatti for approval

tengqm · 2019-07-26T03:04:22Z

/approve

k8s-ci-robot · 2019-07-26T03:04:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added Tencent Cloud Production Environment Solution

487f0a8

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2019

k8s-ci-robot requested review from brendandburns and mikedanese July 5, 2019 04:27

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 5, 2019

k8s-ci-robot assigned jaredbhatti Jul 5, 2019

yunxji changed the title ~~Added Tencent Cloud Production Environment Solution~~ Add something about Tengxun Cloud Jul 5, 2019

Add an article on how to run kubernetes on Tencent Kubernetes Engine …

386a174

…: content/en/docs/setup/production-environment/turnkey/tke.md

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2019

yunxji changed the title ~~Add something about Tengxun Cloud~~ Add something about Tencent Cloud Jul 5, 2019

sftim reviewed Jul 11, 2019

View reviewed changes

yunxji added 2 commits July 12, 2019 11:07

Document modifications have been made as recommended by reviewer sfti…

4b7124f

…m. Please select this document when merging.

Document optimization

39212b8

sftim reviewed Jul 15, 2019

View reviewed changes

yunxji added 2 commits July 15, 2019 19:19

Modify the contents of the document : content/en/docs/setup/productio…

41a7ee7

…n-environment/turnkey/tke.md

Add A What's Next section

796e6f9

sftim reviewed Jul 16, 2019

View reviewed changes

Add content: TKE is a Certified Kubernetes product.

5f27e08

sftim reviewed Jul 17, 2019

View reviewed changes

content/en/docs/setup/production-environment/turnkey/tencent.md Outdated Show resolved Hide resolved

sftim suggested changes Jul 17, 2019

View reviewed changes

Add reviewers and other information.

9c65bcf

Delete a space

d653eaa

Change information about reviewers

51be38a

yunxji commented Jul 19, 2019

View reviewed changes

sftim reviewed Jul 19, 2019

View reviewed changes

content/en/docs/setup/production-environment/turnkey/tencent.md Outdated Show resolved Hide resolved

Remove reviewers.

87649d2

k8s-ci-robot assigned sftim Jul 22, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019

k8s-ci-robot assigned tengqm Jul 25, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019

k8s-ci-robot merged commit c866b20 into kubernetes:master Jul 26, 2019


		[Tencent Cloud Tencent Kubernetes Engine (TKE)](https://intl.cloud.tencent.com/product/tke) provides native Kubernetes container management services. You can deploy and manage a Kubernetes cluster with TKE in just a few steps. For detailed directions, see [Deploy Tencent Kubernetes Engine](https://intl.cloud.tencent.com/document/product/457/11741).

		In addition to full compatibility with the native Kubernetes API,TKE features Kubernetes plugins of Tencent Cloud such as [Cloud Block Storage](https://intl.cloud.tencent.com/product/cbs) and [Cloud Load Balancer](https://intl.cloud.tencent.com/product/clb), helping you build a complete system of container services and functions. For learn more about TKE in its official [TKE documentation](https://intl.cloud.tencent.com/document/product/457).


		The core of Tencent Kubernetes Engine is open source and available [on GitHub](https://github.com/TencentCloud/tencentcloud-cloud-controller-manager/).

		When using TKE to create a Kubernetes cluster, you can choose managed mode or independent deployment mode. In addition, you can customize the deployment as needed; for example, you can choose an existing CVM instance for cluster creation or enable Kube-proxy IPVS.

Conversation

yunxji commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yunxji commented Jul 5, 2019

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yunxji commented Jul 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yunxji commented Jul 12, 2019

Uh oh!

tengqm commented Jul 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

yunxji commented Jul 18, 2019

Uh oh!

yunxji commented Jul 18, 2019

Uh oh!

sftim commented Jul 18, 2019

Uh oh!

yunxji commented Jul 19, 2019

Uh oh!

yunxji left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sftim commented Jul 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yunxji commented Jul 23, 2019

Uh oh!

yunxji commented Jul 25, 2019

Uh oh!

yunxji commented Jul 25, 2019

Uh oh!

yunxji commented Jul 26, 2019

Uh oh!

tengqm commented Jul 26, 2019

Uh oh!

k8s-ci-robot commented Jul 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

yunxji commented Jul 5, 2019 •

edited

Loading

netlify bot commented Jul 5, 2019 •

edited

Loading

yunxji commented Jul 12, 2019 •

edited

Loading

yunxji left a comment •

edited

Loading

sftim commented Jul 22, 2019 •

edited

Loading