Skip to content

ImagePolicyWebhook: config can be embedded#15233

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahmedtd:image-policy-webhook-config
Jul 24, 2019
Merged

ImagePolicyWebhook: config can be embedded#15233
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
ahmedtd:image-policy-webhook-config

Conversation

@ahmedtd
Copy link
Copy Markdown
Contributor

@ahmedtd ahmedtd commented Jul 2, 2019

All admission control plugins support two modes for specifying their configuration: linking to an external file using the path key in the shared admission configuration file, or directly embedding the configuration using the configuration key in the shared admission configuration file.

This commit makes the ImagePolicyWebhook documentation mention the embedded configuration option.

@ahmedtd
ImagePolicyWebhook: config can be embedded
fedebad 
All admission control plugins support two modes for specifying their
configuration: linking to an external file using the `path` key in the
shared admission configuration file, or directly embedding the
configuration using the `configuration` key in the shared admission
configuration file.

This commit makes the ImagePolicyWebhook documentation mention the
embedded configuration option.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 2, 2019

Welcome @ahmedtd!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 2, 2019
@ahmedtd
Copy link
Copy Markdown
Contributor Author

ahmedtd commented Jul 2, 2019

/assign @bradtopol

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 2, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit fedebad

https://deploy-preview-15233--kubernetes-io-master-staging.netlify.com

@ahmedtd
Copy link
Copy Markdown
Contributor Author

ahmedtd commented Jul 2, 2019

/assign @thockin @derekwaynecarr

@ahmedtd
Copy link
Copy Markdown
Contributor Author

ahmedtd commented Jul 2, 2019

/unassign @bradtopol

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 6, 2019

/approve

needs a tech lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2019
@tengqm tengqm added Needs Tech Review and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2019
@ahmedtd
Copy link
Copy Markdown
Contributor Author

ahmedtd commented Jul 24, 2019

/assign @mikedanese

@ahmedtd ahmedtd mentioned this pull request Jul 24, 2019
Closed
@thockin
Copy link
Copy Markdown
Member

thockin commented Jul 24, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 51de06b into kubernetes:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@thockin thockin Awaiting requested review from thockin

Assignees

@mikedanese mikedanese

@thockin thockin

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ahmedtd @k8s-ci-robot @tengqm @thockin @mikedanese @derekwaynecarr @bradtopol