Skip to content

Issue with k8s.io/zh/docs/tutorials/kubernetes-basics/scale/scale-intro/#15179

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
mhamdisemah:15147
Jul 24, 2019
Merged

Issue with k8s.io/zh/docs/tutorials/kubernetes-basics/scale/scale-intro/#15179
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
mhamdisemah:15147

Conversation

@mhamdisemah
Copy link
Copy Markdown
Contributor

@mhamdisemah mhamdisemah commented Jun 28, 2019

fixes #15147

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 28, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Jun 28, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7542259

https://deploy-preview-15179--kubernetes-io-master-staging.netlify.com

@mcbenjemaa
Copy link
Copy Markdown
Member

mcbenjemaa commented Jun 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@mcbenjemaa
Copy link
Copy Markdown
Member

mcbenjemaa commented Jun 28, 2019

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
mcbenjemaa
mcbenjemaa suggested changes Jun 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@mcbenjemaa mcbenjemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language zh

@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jun 28, 2019
seokho-son
seokho-son reviewed Jul 3, 2019
View reviewed changes
content/ko/docs/tutorials/kubernetes-basics/scale/scale-intro.html Outdated
</div>

<div class="item">
<div class="item ">
Copy link
Copy Markdown
Member

@seokho-son seokho-son Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhamdisemah , Thank you for your contribution.
However, the change for the content/ko/docs/tutorials/kubernetes-basics/scale/scale-intro.html seems a mistake.
In the preview (https://deploy-preview-15179--kubernetes-io-master-staging.netlify.com/ko/docs/tutorials/kubernetes-basics/scale/scale-intro/) ,
Carousel is not working for the Korean document.

Copy link
Copy Markdown
Contributor Author

@mhamdisemah mhamdisemah Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is for ZH document not for KO

Copy link
Copy Markdown
Contributor

@gochist gochist Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhamdisemah 👋 This PR contains Korean content change which causes a conflict. Please resolve the conflict and remove the "language/ko" label.

@mhamdisemah
Copy link
Copy Markdown
Contributor Author

mhamdisemah commented Jul 3, 2019 •
edited
Loading

/remove-language ko

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed language/ko Issues or PRs related to Korean language labels Jul 3, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2019
@zhangqx2010
Copy link
Copy Markdown
Contributor

zhangqx2010 commented Jul 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2019
@idealhack
Copy link
Copy Markdown
Contributor

idealhack commented Jul 24, 2019

https://deploy-preview-15179--kubernetes-io-master-staging.netlify.com/zh/docs/tutorials/kubernetes-basics/scale/scale-intro/

/lgtm

/assign @SataQiu

@idealhack idealhack mentioned this pull request Jul 24, 2019
Closed
@SataQiu
Copy link
Copy Markdown
Member

SataQiu commented Jul 24, 2019

Thanks @mhamdisemah
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit f7a6551 into kubernetes:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@gochist gochist Awaiting requested review from gochist

+1 more reviewer

@mcbenjemaa mcbenjemaa mcbenjemaa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@idealhack idealhack

@zhangqx2010 zhangqx2010

@SataQiu SataQiu

@mcbenjemaa mcbenjemaa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/zh/docs/tutorials/kubernetes-basics/scale/scale-intro/

8 participants

@mhamdisemah @mcbenjemaa @zhangqx2010 @idealhack @SataQiu @k8s-ci-robot @gochist @seokho-son