[WIP] Add kind to learning environments #15056
[WIP] Add kind to learning environments #15056opowbow wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Welcome @opowbow! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @tfogo |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c684a95 https://deploy-preview-15056--kubernetes-io-master-staging.netlify.com |
|
/cc @justaugustus @munnerz @BenTheElder |
|
|
||
| * multi-node (including HA) clusters | ||
| * building Kubernetes release builds from source | ||
| * make / bash / docker, bazel, or installing from apt, in addition to pre-published builds |
There was a problem hiding this comment.
oops we need to update this upstream, apt was removed
|
thanks for the PR and the CC! I'm not sure what the right approach is re porting / linking. 😅 |
|
I really like this addition! Do we have a mechanism for that today, @zacharysarah? |
I think the content is great! However, I'm not convinced this PR is the way to add it: see this comment on the original issue.
We don't, short of a submodule approach, and adding a solution would probably be non-trivial. To recapitulate, I'd rather add this information to KinD and link to it from k/website than dual-source it or submodule it. |
Hi @zacharysarah !!!! The content in this PR has the same outline as the content in https://kubernetes.io/docs/setup/learning-environment/minikube/. Kubernetes website has a large footprint and users are looking for information to get started with Kubernetes. Right now we only have Minikube as the option to get started with Kubernetes. I agree that it might not be a good idea to recapitulate. However, we could have content to get started with Kubernetes on Kubernetes website and add links for additional information to https://github.com/kubernetes-sigs/kind. In short, we could emulate what https://github.com/kubernetes/minikube has to avoid dual-source or submodule KinD. |
...And Minikube tutorial source lives in k/website. This PR proposes to add content from a source outside the k/website chain, effectively dual-sourcing it, but provides no method to automate freshness or ensure that content receives adequate review. While I trust that the intentions of everyone involved are 💯 the best, this PR effectively proposes an end run around SIG Docs. That's not a model I want to set up or support, even with the best of intentions. |
|
I agree that dual sourcing is not the best approach going forward....is a better way to simply have a KinD page on the learning-environment page ( so users of k/website are informed of this way to set up a cluster) , but the page consists of links back to the actual KinD pages...as @zacharysarah suggested above. The page can be sectioned like the minikube page..and introduced ...but content is wholly linked back to KinD docs? ( again as @zacharysarah suggests ). Thanks for all your helpful comments! |
|
@opowbow 👋 Please feel free to /close |
|
@zacharysarah: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this refers to git issue #14829
#14829
This is still being worked on