Skip to content

Initialize Federation in Bahasa Indonesia.#14148

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
irvifa:id/federation
May 5, 2019
Merged

Initialize Federation in Bahasa Indonesia.#14148
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
irvifa:id/federation

Conversation

@irvifa
Copy link
Copy Markdown
Member

@irvifa irvifa commented May 3, 2019

This address #13929

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2019
@irvifa
Copy link
Copy Markdown
Member Author

irvifa commented May 3, 2019

/assign @girikuncoro
/assign

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2019
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 3, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented May 3, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 697fab5

https://deploy-preview-14148--kubernetes-io-master-staging.netlify.com

Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general format and all looking good, just need to address typos and minor rephrases. Good job! 🎉

@@ -0,0 +1,195 @@
---
title: Federation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do Federation or Federasi?

If we decide to use Federation, we will need to address this for previously translated pages (I remember some we use kluster federasi)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is related to kubernetes's term i'm not sure whether to chane it or not

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's stick to federation for now

@@ -0,0 +1,3 @@
---
headless: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this index.md file for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure but in the en they have this

@girikuncoro
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit c14937f into kubernetes:master May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants