Skip to content

Add reference and link to kubeconfig on kubectl page#14059

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thecrudge:cody1
Apr 26, 2019
Merged

Add reference and link to kubeconfig on kubectl page#14059
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
thecrudge:cody1

Conversation

@thecrudge
Copy link
Copy Markdown
Contributor

@thecrudge thecrudge commented Apr 26, 2019

Add reference and link to kubeconfig on kubectl page

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 26, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 26, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cb46842

https://deploy-preview-14059--kubernetes-io-master-staging.netlify.com

@thecrudge
Copy link
Copy Markdown
Contributor Author

thecrudge commented Apr 26, 2019

/assign cody-clark

The original CC: Can you review this?

@thecrudge thecrudge mentioned this pull request Apr 26, 2019
Closed
2 tasks
@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Apr 26, 2019

Preview: https://deploy-preview-14059--kubernetes-io-master-staging.netlify.com/docs/reference/kubectl/overview/

It looks like the two "--" before kubeconfig are rendering as an em dash. Can you try backticks?

For example: --kubeconfig like on the kubeconfig page

@thecrudge thecrudge mentioned this pull request Apr 26, 2019
Closed
6 tasks
@cody-clark
Copy link
Copy Markdown
Contributor

cody-clark commented Apr 26, 2019

It's a good thing our user names are pretty distinct :) @thecrudge

And looks great!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit fe663ea into kubernetes:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@hw-qiaolei hw-qiaolei Awaiting requested review from hw-qiaolei

Assignees

@cody-clark cody-clark

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thecrudge @cody-clark @k8s-ci-robot