Skip to content

Update install-kubectl.md#14036

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
shavidissa:patch-24
Apr 25, 2019
Merged

Update install-kubectl.md#14036
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
shavidissa:patch-24

Conversation

@shavidissa
Copy link
Copy Markdown
Contributor

@shavidissa shavidissa commented Apr 25, 2019

I thought this organization would give the users a better idea on what method to select based on the OS they use.

Initially, I was a wee bit confused when I saw how to Install kubectl binary with curl on the Mac OS and then another section on how to install Kubectl on the Mac OS.

Now, I moved the content under the $subject to the respective OS section.

P.S: I am still in the process of testing out the steps. :)

I thought this organization would give the users a better idea of what method to select based on the OS they use. 

Initially, I was a wee bit confused when I saw how to Install kubectl binary with curl on the Mac OS and then another section on how to install Kubectl on the Mac OS.

Now, I moved the content under the $subject to the respective OS section. 

P.S: I am still in the process of testing out the steps. :)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 25, 2019
@shavidissa
Copy link
Copy Markdown
Contributor Author

/assign @zacharysarah
/assign @Rajakavitha1
/assign @cody-clark

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 25, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 67a5fca

https://deploy-preview-14036--kubernetes-io-master-staging.netlify.com

@Rajat-0
Copy link
Copy Markdown

Rajat-0 commented Apr 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Apr 25, 2019

Hi @shavidissa !!!!

Downloading kubectl binary with curl on any OS is the common step before you begin the installation of kubectl.

In other words cURL is a tool to transfer data from and to a server using a set of supported network protocols.

Downloading is the process of pulling the data from the remote source to the local storage of your system. In this case we are downloading the kubectl binaries using cURL command and creating an executable file.

Installation is the process of putting application files in proper locations on the storage of your system and updating the configuration on the system to reflect the fact that installed software is now usable and can be easily executed in the environment of your system.

My suggestion would be to:

a. Rephrase "Install kubectl binary with curl" to "Download kubectl binary with curl and create an executable" or something to that effect. And make it a prerequisite step before you proceed with the installation on each of the OS in the new organization of the content that you propose.

b. Just rephrase "Install kubectl binary with curl" to "Download kubectl binary with curl and create an executable"or something to that effect in the current organisation of the content.

PS: I have not tried the steps yet.

@shavidissa
Copy link
Copy Markdown
Contributor Author

Hi @Rajakavitha1,

Personally, the current title that was originally in the wiki seems okay since this is the normal terminology used in the tech community. When you say installing something with curl, I think it is implied that we download something from curl and we execute what is downloaded. And especially, if you say “create an executable”, it may not sound correct since we don’t really create an executable (in the way we compile some code and create an executable) but rather, we just download it and run it. So maybe we should just keep it short as it is now :).

Let me know if it still needs to be changed :)

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Apr 25, 2019

Hi @Rajakavitha1,

Personally, the current title that was originally in the wiki seems okay since this is the normal terminology used in the tech community. When you say installing something with curl, I think it is implied that we download something from curl and we execute what is downloaded. And especially, if you say “create an executable”, it may not sound correct since we don’t really create an executable (in the way we compile some code and create an executable) but rather, we just download it and run it. So maybe we should just keep it short as it is now :).

Let me know if it still needs to be changed :)

The only reason I suggested a rephrase was because:
"Initially, I was a wee bit confused when I saw how to Install kubectl binary with curl on the Mac OS and then another section on how to install Kubectl on the Mac OS."

I like a simple title too :)

Also, my understanding was that "Install kubectl binary with curl" is a task before we install kubectl on any of the OS and not an option like the rest "Install with Homebrew on macOS" or "Install with Macports on macOS". I may be completely wrong :)

@shavidissa
Copy link
Copy Markdown
Contributor Author

Ooo got it @Rajakavitha1 :D .. No that is another way to install kubectl on the OS similar to installing kubectl using homebrew.

@jaredbhatti
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaredbhatti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit eaf7658 into kubernetes:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants