Skip to content

Add translations for Declarative Config for Bahasa Indonesia#14030

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
qbl:master
Apr 26, 2019
Merged

Add translations for Declarative Config for Bahasa Indonesia#14030
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
qbl:master

Conversation

@qbl
Copy link
Copy Markdown
Contributor

@qbl qbl commented Apr 25, 2019

This PR addresses #13929.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 25, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 25, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d543951

https://deploy-preview-14030--kubernetes-io-master-staging.netlify.com

@qbl
Copy link
Copy Markdown
Contributor Author

qbl commented Apr 25, 2019

/assign @girikuncoro

@girikuncoro girikuncoro requested review from irvifa and removed request for jimangel April 25, 2019 03:11
@girikuncoro girikuncoro mentioned this pull request Apr 25, 2019
Closed
80 tasks
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 25, 2019

Overall it's good on my side, however it's seems like you forgot to put the _index.md
Screen Shot 2019-04-25 at 12 20 02

Please add _index.md so the link can be referenced as Bahasa Indonesia instead of EN
https://deploy-preview-14030--kubernetes-io-master-staging.netlify.com/id/docs/

irvifa
irvifa suggested changes Apr 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about _index.md inside object-management-kubectl directory 🙇

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 26, 2019 •
edited
Loading

Hmm I wonder why the directory still listed as EN 🤔 Hmm sorry I forgot seems like it's because on your fork there's no _index.md for overview. Ok from me actually, do you have any feedback @girikuncoro

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit e671202 into kubernetes:master Apr 26, 2019
@girikuncoro girikuncoro mentioned this pull request Apr 28, 2019
Merged
@qbl qbl mentioned this pull request Aug 19, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qbl @irvifa @k8s-ci-robot @girikuncoro