Skip to content

Add new translation in Bahasa Indonesia#14015

Merged
k8s-ci-robot merged 7 commits intokubernetes:masterfrom
danninov:master
May 5, 2019
Merged

Add new translation in Bahasa Indonesia#14015
k8s-ci-robot merged 7 commits intokubernetes:masterfrom
danninov:master

Conversation

@danninov
Copy link
Copy Markdown
Contributor

@danninov danninov commented Apr 24, 2019

This PR addresses #13929

/language id

@k8s-ci-robot k8s-ci-robot added the language/id Issues or PRs related to Indonesian language label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 24, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 24, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4c28982

https://deploy-preview-14015--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro removed the request for review from jimangel April 24, 2019 17:39
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Apr 24, 2019

/assign

@girikuncoro girikuncoro mentioned this pull request Apr 24, 2019
Closed
80 tasks
irvifa
irvifa suggested changes Apr 25, 2019
View reviewed changes
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 25, 2019

/assign

girikuncoro
girikuncoro requested changes Apr 25, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you for your first contribution to Kubernetes docs! 🎉 🎉

In general, to make it consistent with the rest of translated pages, some nits:

the rests and major sentences I would keep the same for now, generally understandable. good job!
the openstack paragraphs are pretty long and openstack specific, probably in the future need help from openstack employees to edit/review it

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented May 1, 2019

@danninov any update on this?

@danninov
Copy link
Copy Markdown
Contributor Author

danninov commented May 2, 2019

@danninov any update on this?

Sorry for delay. I've made revision to the translation.

@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented May 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit ae4b297 into kubernetes:master May 5, 2019
@danninov danninov mentioned this pull request Aug 8, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro girikuncoro requested changes

+1 more reviewer

@irvifa irvifa irvifa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danninov @girikuncoro @irvifa @k8s-ci-robot