Skip to content

Fix #13871 - Update reference link 'kubefed unjoin' in set-up-cluster-federation-kubefed#14000

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
daminisatya:fix_13871
Apr 26, 2019
Merged

Fix #13871 - Update reference link 'kubefed unjoin' in set-up-cluster-federation-kubefed#14000
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
daminisatya:fix_13871

Conversation

@daminisatya
Copy link
Copy Markdown
Contributor

@daminisatya daminisatya commented Apr 24, 2019

fixes - #13871

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 24, 2019

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 24, 2019
@daminisatya
Copy link
Copy Markdown
Contributor Author

daminisatya commented Apr 24, 2019

/assign @jaredbhatti
/assign @Rajakavitha1

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 87a16b3

https://deploy-preview-14000--kubernetes-io-master-staging.netlify.com

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 24, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5047fb5

https://deploy-preview-14000--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Apr 25, 2019

Thanks for the PR @daminisatya !

I would like @jimangel to take a look at this because he has been working on this.

@Rajakavitha1
Copy link
Copy Markdown
Contributor

Rajakavitha1 commented Apr 25, 2019

/assign @jimangel

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Apr 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit f8fbd6d into kubernetes:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madhusudancs madhusudancs Awaiting requested review from madhusudancs

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@jimangel jimangel

@tengqm tengqm

@jaredbhatti jaredbhatti

@Rajakavitha1 Rajakavitha1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daminisatya @k8s-ci-robot @Rajakavitha1 @tengqm @jimangel @jaredbhatti