Skip to content

Add content/pt/docs/concepts/architecture/cloud-controller.md#13979

Merged
femrtnz merged 1 commit intokubernetes:masterfrom
femrtnz:master
Apr 24, 2019
Merged

Add content/pt/docs/concepts/architecture/cloud-controller.md#13979
femrtnz merged 1 commit intokubernetes:masterfrom
femrtnz:master

Conversation

@femrtnz
Copy link
Copy Markdown
Contributor

@femrtnz femrtnz commented Apr 23, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: femrtnz

If they are not already assigned, you can assign the PR to them by writing /assign @femrtnz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 23, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 758025a

https://deploy-preview-13979--kubernetes-io-master-staging.netlify.com

This was referenced Apr 23, 2019
Closed
Closed
@femrtnz
Copy link
Copy Markdown
Contributor Author

femrtnz commented Apr 23, 2019

Hey @jcjesus . Could you please have a look this PR?

you can review the page here as well: https://deploy-preview-13979--kubernetes-io-master-staging.netlify.com/pt/docs/concepts/architecture/cloud-controller/

/assign @jcjesus

@femrtnz femrtnz changed the title WIP: Add content/pt/docs/concepts/architecture/cloud-controller.md Add content/pt/docs/concepts/architecture/cloud-controller.md Apr 23, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2019
@jcjesus
Copy link
Copy Markdown
Contributor

jcjesus commented Apr 24, 2019

@femrtnz in cloud-controller.md file, you translated Service Controller to Portuguese, but Node Controller and other not. I will suggest you translate all or neither.

@jcjesus
Copy link
Copy Markdown
Contributor

jcjesus commented Apr 24, 2019

@femrtnz I will suggest to you translate "Design de Arquitetura" to "Projeto de Arquitetura (Design)"

@jcjesus
Copy link
Copy Markdown
Contributor

jcjesus commented Apr 24, 2019 •
edited
Loading

Hi @femrtnz!
I will suggest to you translate "Controlador de Node" to "Controlador de Nós", to not confusing with "NodeJS", hehehe

In this file, were contain the word "Node" I think we need translate to "Nó" and keep the pattern to translation , 'cause we have "Node Controller" and "Controlador de Node" in the same file.

@jcjesus
Copy link
Copy Markdown
Contributor

jcjesus commented Apr 24, 2019

/assign @femrtnz

@femrtnz
Copy link
Copy Markdown
Contributor Author

femrtnz commented Apr 24, 2019

Hi @femrtnz!
I will suggest to you translate "Controlador de Node" to "Controlador de Nós", to not confusing with "NodeJS", hehehe

In this file, where contains the word "Node" I think we need translate to "Nó" and keep the pattern to translation , 'cause we have "Node Controller" and "Controlador de Node" in the same file.

@jcjesus Thanks for the review. I'm just worried to translate a specific Kubernetes name where we can lose the meaning within the context. e.g, using kubectl get nodes

@femrtnz
Add cloud contraller pt translation
758025a 
Updating cloud controller

Add cloud contraller pt translation

add Conceitos sobre Cloud Controller Manager

addressing pr comments
@femrtnz femrtnz merged commit 891fa99 into kubernetes:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcjesus jcjesus Awaiting requested review from jcjesus

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@jcjesus jcjesus

@femrtnz femrtnz

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@femrtnz @k8s-ci-robot @jcjesus