Skip to content

Translate Pod overview in Bahasa Indonesia#13968

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
zufardhiyaulhaq:master
Apr 24, 2019
Merged

Translate Pod overview in Bahasa Indonesia#13968
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
zufardhiyaulhaq:master

Conversation

@zufardhiyaulhaq
Copy link
Copy Markdown
Contributor

@zufardhiyaulhaq zufardhiyaulhaq commented Apr 23, 2019

This PR addresses #13929

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 23, 2019
@zufardhiyaulhaq
Copy link
Copy Markdown
Contributor Author

zufardhiyaulhaq commented Apr 23, 2019

/assign @girikuncoro

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 23, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4b5526a

https://deploy-preview-13968--kubernetes-io-master-staging.netlify.com

@girikuncoro girikuncoro mentioned this pull request Apr 23, 2019
Closed
80 tasks
@girikuncoro girikuncoro removed the request for review from xiangpengzhao April 23, 2019 13:22
irvifa
irvifa reviewed Apr 23, 2019
View reviewed changes
girikuncoro
girikuncoro requested changes Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks for your contribution! some minor changes and conventions required to be consistent with other translated pages:

  • anda -> kamu
  • sumber daya -> resource
  • controller -> kontroler, except for kubernetes concept i.e. replication controller
  • templat -> template

edit: templat is fine https://kbbi.kemdikbud.go.id/entri/templat

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 23, 2019

/assign

girikuncoro
girikuncoro requested changes Apr 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, one last formatting issues 😄

@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2019
@girikuncoro
Copy link
Copy Markdown
Contributor

girikuncoro commented Apr 24, 2019

thanks for your first contribution to kubernetes docs! 🎉🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@irvifa
Copy link
Copy Markdown
Member

irvifa commented Apr 24, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro, irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7fd505e into kubernetes:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girikuncoro girikuncoro girikuncoro requested changes

+1 more reviewer

@irvifa irvifa irvifa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zufardhiyaulhaq @irvifa @girikuncoro @k8s-ci-robot