Skip to content

Update minikube.md#13803

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yzhong52:patch-1
Apr 25, 2019
Merged

Update minikube.md#13803
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
yzhong52:patch-1

Conversation

@yzhong52
Copy link
Copy Markdown
Contributor

@yzhong52 yzhong52 commented Apr 12, 2019

It is minor, but I think it is more readable by moving the comments out of the code blocks since it is the document not code.

This is how it looks currently here https://kubernetes.io/docs/setup/minikube/:

Screen Shot 2019-04-12 at 2 51 11 PM

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 12, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from balopat and dlorenc April 12, 2019 18:53
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 12, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c2a08c9

https://deploy-preview-13803--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Copy Markdown
Contributor

DanyC97 commented Apr 23, 2019

@yzhong52 could you please sign the CLA?

@yzhong52
Copy link
Copy Markdown
Contributor Author

yzhong52 commented Apr 24, 2019

@DanyC97 Just signed. Sorry for the delay.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 24, 2019
@DanyC97
Copy link
Copy Markdown
Contributor

DanyC97 commented Apr 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Apr 25, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6f62dc3 into kubernetes:master Apr 25, 2019
@yzhong52 yzhong52 deleted the patch-1 branch May 26, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@DanyC97 DanyC97

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yzhong52 @k8s-ci-robot @DanyC97 @tengqm