Skip to content

add rui to sig-docs-zh team#11383

Merged
k8s-ci-robot merged 2 commits intokubernetes:release-1.12from
chenrui333:add-rui-for-sig-docs-zh
Nov 29, 2018
Merged

add rui to sig-docs-zh team#11383
k8s-ci-robot merged 2 commits intokubernetes:release-1.12from
chenrui333:add-rui-for-sig-docs-zh

Conversation

@chenrui333
Copy link
Copy Markdown
Member

@chenrui333 chenrui333 commented Nov 28, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2018
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 28, 2018 •
edited
Loading

Deploy preview for k8s-v1-12 processing.

Built with commit 2c4e487

https://app.netlify.com/sites/k8s-v1-12/deploys/5bff580a40e2a470ec829e0f

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2018
@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Nov 28, 2018

/cc @zacharysarah @bradtopol @tengqm

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 29, 2018

stats:
31+ PRs merged: https://github.com/kubernetes/website/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+author%3Achenrui333
10+ PRs reviewed: https://github.com/kubernetes/website/pulls?utf8=%E2%9C%93&q=reviewed-by%3Achenrui333+

Rui has been an emerging active contributor to the project. Would be happy to have him in the team.

@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Nov 29, 2018

forced push to fix netlify deploy issue with the latest release-1.12 as base.

@idealhack
Copy link
Copy Markdown
Contributor

idealhack commented Nov 29, 2018

please make it alphabetical

@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Nov 29, 2018

@idealhack that is good point, updated. Thanks!

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2018
@zacharysarah
Copy link
Copy Markdown
Contributor

zacharysarah commented Nov 29, 2018

@chenrui333 👋Thanks for opening this PR, great to have you on board! Two things:

  1. Please open another PR for master. It's OK to wait until this PR merges. 😸

  2. Please configure your editor to avoid linting whitespace for unrelated lines. (L131, L141)

Otherwise LGTM 👍

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 46c56da into kubernetes:release-1.12 Nov 29, 2018
@chenrui333 chenrui333 mentioned this pull request Nov 29, 2018
Merged
@chenrui333 chenrui333 deleted the add-rui-for-sig-docs-zh branch November 29, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@tengqm tengqm Awaiting requested review from tengqm

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chenrui333 @tengqm @idealhack @zacharysarah @k8s-ci-robot