Skip to content

Fix typo on serviceName#11329

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
OrlSan:patch-1
Nov 27, 2018
Merged

Fix typo on serviceName#11329
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
OrlSan:patch-1

Conversation

@OrlSan
Copy link
Copy Markdown
Contributor

@OrlSan OrlSan commented Nov 26, 2018

A minor typo fix on the Ingress documentation already published on kubernetes.io

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 26, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2018
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 26, 2018
@OrlSan
Copy link
Copy Markdown
Contributor Author

OrlSan commented Nov 26, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 26, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Nov 26, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2f0d414

https://deploy-preview-11329--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 27, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7c04f85 into kubernetes:master Nov 27, 2018
@OrlSan OrlSan deleted the patch-1 branch November 27, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bprashanth bprashanth Awaiting requested review from bprashanth

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OrlSan @k8s-ci-robot @k8sio-netlify-preview-bot @tengqm