Skip to content

Update officially supported client libraries#10792

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
drubin:patch-1
Nov 6, 2018
Merged

Update officially supported client libraries#10792
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
drubin:patch-1

Conversation

@drubin
Copy link
Copy Markdown
Contributor

@drubin drubin commented Oct 31, 2018

Update officially supported client libraries to match ones listed https://kubernetes.io/docs/reference/using-api/client-libraries/#officially-supported-kubernetes-client-libraries

I was browsing and it was confusing that we listed only 2 of the supported libraries.

I think it makes sense to list them all or just link to the official list located at https://kubernetes.io/docs/reference/using-api/client-libraries/#officially-supported-kubernetes-client-libraries

I would be happy to update the docs either way?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 31, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Oct 31, 2018

Deploy preview for kubernetes-io-master-staging failed.

Built with commit 8a9f1f7

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bd987773813f038302339a8

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Oct 31, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging failed.

Built with commit c5cf4ef

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5be09263e5cd161fb3319989

@drubin
Copy link
Copy Markdown
Contributor Author

drubin commented Oct 31, 2018

I signed it

xiangpengzhao
xiangpengzhao reviewed Nov 2, 2018
View reviewed changes
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 2, 2018
@k8s-ci-robot k8s-ci-robot requested a review from chenopis November 3, 2018 15:37
@chenopis
Copy link
Copy Markdown
Contributor

chenopis commented Nov 5, 2018

@drubin You'll need to rebase to fix a build issue that snuck into the master branch. Once the build tests pass and I check the preview, we can merge this. LGTM

@drubin
Copy link
Copy Markdown
Contributor Author

drubin commented Nov 5, 2018

@chenopis Rebased. Hopefully, the tests pass.

If you need anything else updated let me know.

@chenopis
Copy link
Copy Markdown
Contributor

chenopis commented Nov 6, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit e839031 into kubernetes:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

2 more reviewers

@xiangpengzhao xiangpengzhao xiangpengzhao left review comments

@chenopis chenopis chenopis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chenopis chenopis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drubin @k8s-ci-robot @k8sio-netlify-preview-bot @chenopis @xiangpengzhao