Skip to content

Describe what file to edit#10790

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
robertdebock:patch-1
Nov 2, 2018
Merged

Describe what file to edit#10790
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
robertdebock:patch-1

Conversation

@robertdebock
Copy link
Copy Markdown
Contributor

It was not clear where the yaml blob should be saved in. Added a single like that clears up what file to edit.

It was not clear where the yaml blob should be saved in. Added a single like that clears up what file to edit.
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit c9383be

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bd94f8e792f8935053683e9

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit c9383be

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bd94f8e73f2cf4a116215e9

@robertdebock
Copy link
Copy Markdown
Contributor Author

CLA has been signed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 31, 2018
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Nov 1, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@cody-clark
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cody-clark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1749327 into kubernetes:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants