Skip to content

[WIP] Add imported docs update to site build#10381

Closed
lucperkins wants to merge 2 commits intokubernetes:masterfrom
lucperkins:lperkins/update-imported-docs-build
Closed

[WIP] Add imported docs update to site build#10381
lucperkins wants to merge 2 commits intokubernetes:masterfrom
lucperkins:lperkins/update-imported-docs-build

Conversation

@lucperkins
Copy link
Copy Markdown
Contributor

@lucperkins lucperkins commented Sep 25, 2018

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2018
@lucperkins
Copy link
Copy Markdown
Contributor Author

lucperkins commented Sep 25, 2018

/assign @zparnold

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Sep 25, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 500f962

https://deploy-preview-10381--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Sep 25, 2018 •
edited by netlify bot
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c4bc391

https://deploy-preview-10381--kubernetes-io-master-staging.netlify.com

@lucperkins
Copy link
Copy Markdown
Contributor Author

lucperkins commented Sep 27, 2018

@zparnold One potential issue I see here is that there's already content in these various directories that gets updated by the script (rather than created by the script). This means that you can run the site locally (or look at a Netlify preview build) and see outdated versions of those docs if you don't run the script. Do you think this could be confusing for users?

@zacharysarah zacharysarah mentioned this pull request Oct 1, 2018
Merged
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Dec 26, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2018
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jan 16, 2019

Looks good.

@zparnold
Copy link
Copy Markdown
Contributor

zparnold commented Feb 8, 2019

Sounds like this is good @lucperkins so if you can merge the upstream Makefile changes then we can get this in!
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 8, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zparnold

If they are not already assigned, you can assign the PR to them by writing /assign @zparnold in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented May 9, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2019
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 8, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 8, 2019
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jul 8, 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 8, 2019

@fejta-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@zparnold zparnold

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lucperkins @k8sio-netlify-preview-bot @fejta-bot @tengqm @zparnold @k8s-ci-robot