Added feature-gates deprecation guidelines and policy as per discussi…#10294
Conversation
…on: SIG-architecture meeting
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 19132e4 https://deploy-preview-10294--kubernetes-io-master-staging.netlify.com |
|
/assign @bradtopol |
|
/hold |
|
the preview and the definitions SGTM as per the google docs edits.
with regard to alpha gates, something else i've remembered that kubeadm is currently doing is the following. but we can consider this as an edge case. WRT the above, a possible addition to the document can be that maintainers might decide to extend the deprecation period, if see fit. |
|
Seems pretty close to what I expected |
|
@neolit123 , Since enforcement was a topic during the discussion, I thought we should write a guideline that is/sounds less flexible, at the same time pointing out the fact that not all feature-gates (or their maintainers) respect this guideline. do you think we need a new sentence to add flexibility? |
|
@anlunas thinking about it a bit more i think this extra case that i pointed out it already covered. the lower and upper bounds provide sufficient detail for both developers and contributors. |
Fixes and initial feedback incorporated.
Removed complicated sentence that is better phrased one sentence later.
|
/assign @thockin Tim, please approve this for sig-arch ( @jdumars and @bgrant0607 tagged you as approver on sig-arch slack ) :) -- Dims |
thockin
left a comment
There was a problem hiding this comment.
Sorry for nit-picking. Trying to make it is aminimal and precise as possible.
Re-structured following key ideas from the feedback.
|
Seems like this is a lot better than not being there and feedback has been incorporated. /lgtm |
|
Thanks for persevering :) |
Incorporated 'invocation triggers warning' and what to do when disabling a no-op.
Announced for completed
|
/assign @thockin |
|
A related question was raised on kubernetes/kubernetes#68230 (comment) that isn't covered by the policy: From @liggitt:
Should we extend the policy to cover this case? |
This line was intended to address it:
|
|
Oh, got it, I missed that. Thanks! |
|
/hold cancel |
|
@kubernetes/sig-docs-en-owners @kubernetes/sig-docs-en-reviews Can one of you please |
|
@dims Reviewing now 👀 |
zacharysarah
left a comment
There was a problem hiding this comment.
Looks good! ✨ Here's some feedback for cleaner copy. I'm requesting changes, but also approving and holding--I'd like to see the changes prior to merge, but I understand if these changes are time sensitive. 👍
If you decide to make changes, the approval will stay--any org member can /lgtm and /hold cancel when you're ready for subsequent review.
| correctness of applications running on Kubernetes or that impact the | ||
| administration of Kubernetes clusters, and which are being removed entirely. | ||
|
|
||
| An exception to the above rule is **feature-gates**. Feature gates are key=value |
There was a problem hiding this comment.
"Feature gates" and "feature-gates" seem to be used interchangeably.
Let's standardize on "feature gates".
Also, nit: this should be italics, not bold.
There was a problem hiding this comment.
@zacharysarah Thanks a lot for your feedback! I will address them asap.
One question on this comment : should I use italics for all instances of feature gates? or only for the first time? thanks!!
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold cancel |
Added feature-gates deprecation guidelines and policy as per discussion SIG-architecture meeting 6th Sept 2018.
https://docs.google.com/document/d/1BusX-ipd9QK58HugU5R-sQF_z4a36oPmkKihv3vTx6o/edit?usp=sharing