-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Localize “email address” placeholder on home page #19272
Copy link
Copy link
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.
Description
This is a Feature Request
What would you like to be added
On the page https://k8s.io/ there is a form that lets you sign up to receive KubeWeekly. That form has placeholder text “email address”, that is currently always English.
Why is this needed
The website should be localized, including placeholder text.
Comments
Here's how to make this change:
- Edit
i18n/config.tomlto add a new section:[input_placeholder_email_address] other = "email address"
- Edit
layouts/index.htmlto replace:
with updated HTML that uses the<input type="email" value="" name="EMAIL" class="email" id="mce-EMAIL" placeholder="email address" aria-label="email" required>
Tshortcode for localization. Have a look at other shortcodes in that page for an idea of how this works. - Submit a pull request.
- Once your pull request is merged, log a new issue for each localization (see https://github.com/kubernetes/website/tree/master/i18n for a list) to get each localization team to add and translate
input_placeholder_email_address. Label each issue for the matching localization language code, eg/language kofor the Korean team. - That's it!
Note You could use a different name from input_placeholder_email_address if you want to.
/help
/kind cleanup
/priority backlog
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.