Skip to content

NFD: Use kubekins image for e2e#29419

Closed
ArangoGutierrez wants to merge 1 commit into
kubernetes:masterfrom
ArangoGutierrez:nfd_fix_e2e
Closed

NFD: Use kubekins image for e2e#29419
ArangoGutierrez wants to merge 1 commit into
kubernetes:masterfrom
ArangoGutierrez:nfd_fix_e2e

Conversation

@ArangoGutierrez

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2023
@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok May 4, 2023 08:47
@ArangoGutierrez

Copy link
Copy Markdown
Contributor Author

/cc @marquiz @fmuyassarov

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs labels May 4, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 4, 2023
@fmuyassarov

Copy link
Copy Markdown
Member

@ArangoGutierrez do we know what are the things that are pre-baked into that image?

@ArangoGutierrez

Copy link
Copy Markdown
Contributor Author

@fmuyassarov fmuyassarov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the e2e presubmit my initial plan was to run the tests on a remote server (Equinix Metal3 currently offered by the CNCF) where we will have all the required tooling and binaries already installed. And in Prow, we would need bare minimum just to trigger the script.
So, I'm not sure why we would need things pre-baked in to the https://github.com/kubernetes/test-infra/blob/9050e0e46b6acb917944a675c5e542d003456b46/images/kubekins-e2e/Dockerfile.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz

marquiz commented May 10, 2023

Copy link
Copy Markdown
Contributor

I don't think we need this. -> close?

@fmuyassarov

Copy link
Copy Markdown
Member

I don't think we need this. -> close?

Yes, I think we can close it.
But let's hear from @ArangoGutierrez .

@ArangoGutierrez

Copy link
Copy Markdown
Contributor Author

/close

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@ArangoGutierrez: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants