Skip to content

Enable e2e test for Alpha feature PodSchedulingReadiness#27862

Closed
Huang-Wei wants to merge 1 commit intokubernetes:masterfrom
Huang-Wei:1.26-alpha-pod-scheduling-gates-e2e
Closed

Enable e2e test for Alpha feature PodSchedulingReadiness#27862
Huang-Wei wants to merge 1 commit intokubernetes:masterfrom
Huang-Wei:1.26-alpha-pod-scheduling-gates-e2e

Conversation

@Huang-Wei
Copy link
Copy Markdown
Member

@Huang-Wei Huang-Wei commented Nov 1, 2022

This will enable the e2e testing CI authored originally in kubernetes/kubernetes#113442.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 1, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2022
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 1, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Huang-Wei
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval by writing /assign @cheftako in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Huang-Wei Huang-Wei mentioned this pull request Nov 1, 2022
Merged
3 tasks
@Huang-Wei Huang-Wei marked this pull request as ready for review November 8, 2022 23:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Nov 8, 2022

k/k changes have been merged, so marking this PR as ready for review.

@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Nov 8, 2022

cc @ahg-g

@ahg-g
Copy link
Copy Markdown
Member

ahg-g commented Nov 9, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022
@Huang-Wei Huang-Wei force-pushed the 1.26-alpha-pod-scheduling-gates-e2e branch from 60aafd7 to ed1a969 Compare December 9, 2022 23:27
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2022
@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Dec 9, 2022

@andrewsykim @cheftako could you please approve this?

@ahg-g needs another /lgtm 🙏

@ahg-g
Copy link
Copy Markdown
Member

ahg-g commented Dec 10, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 7, 2023

@Huang-Wei: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Feb 14, 2023

We may not need it anymore. This feature is gonna be beta soon.

@Huang-Wei Huang-Wei closed this Feb 14, 2023
@Huang-Wei Huang-Wei mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@ahg-g ahg-g

Labels

area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Huang-Wei @k8s-ci-robot @ahg-g