Skip to content

Add introduction of Alpha feature EvenPodsSpread#801

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Huang-Wei:even-pods-spread
Sep 21, 2019
Merged

Add introduction of Alpha feature EvenPodsSpread#801
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Huang-Wei:even-pods-spread

Conversation

@Huang-Wei
Copy link
Copy Markdown
Member

@Huang-Wei Huang-Wei commented Sep 18, 2019

Hope it can catch up with the official release timeline.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 18, 2019

Welcome @Huang-Wei!

It looks like this is your first PR to kubernetes/sig-release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/sig-release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 18, 2019
saschagrunert
saschagrunert approved these changes Sep 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Sep 18, 2019

/assign @lachie83

(Sry for this last-minute PR) It'd good to mention this feature in the release note as users have been demanding for this feature for releases.

idealhack
idealhack reviewed Sep 19, 2019
View reviewed changes
idealhack
idealhack approved these changes Sep 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@idealhack idealhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

AFAIK, release-notes-draft.md is not something we continue to maintain in every release. We can merge this, but as 1.16.0 was out of the door now, this PR should also be transit to changelog in k/k.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2019
@Huang-Wei Huang-Wei mentioned this pull request Sep 19, 2019
Merged
@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Sep 19, 2019

Thanks for the clarification @idealhack, I think we also have to update them on kubernetes.io and relnotes.k8s.io. I will take care of that.

@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Sep 19, 2019

/approve
/lgtm

This was referenced Sep 19, 2019
Merged
Merged
Closed
saschagrunert
saschagrunert requested changes Sep 19, 2019
View reviewed changes
releases/release-1.16/release-notes-draft.md Outdated
- Introduction of the pod overhead feature to the scheduler. This functionality is alpha-level as of
Kubernetes v1.16, and is only honored by servers that enable the PodOverhead feature.gate. ([#78319](https://github.com/kubernetes/kubernetes/pull/78319), [@egernst](https://github.com/egernst))
- Ephemeral containers have been added in alpha. These temporary containers can be added to running pods for purposes such as debugging, similar to how `kubectl exec` runs a process in an existing container. Also like `kubectl exec`, no resources are reserved for ephemeral containers and they are not restarted when they exit. Note that container namespace targeting is not yet implemented, so [process namespace sharing](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/) must be enabled to view process from other containers in the pod. ([#59484](https://github.com/kubernetes/kubernetes/pull/59484), [@verb](https://github.com/verb))
- EvenPodsSpread feature has been added in alpha. This feature introduced an API field `pod.spec.topologySpreadConstraints` to enable users control how Pods are spread across the cluster among failure-domains. ([#77327](https://github.com/kubernetes/kubernetes/pull/77327), [#77760](https://github.com/kubernetes/kubernetes/pull/77760), [#77828](https://github.com/kubernetes/kubernetes/pull/77828), [#79062](https://github.com/kubernetes/kubernetes/pull/79062), [#80011](https://github.com/kubernetes/kubernetes/pull/80011), [#81068](https://github.com/kubernetes/kubernetes/pull/81068), [@Huang-Wei](https://github.com/Huang-Wei))
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- EvenPodsSpread feature has been added in alpha. This feature introduced an API field `pod.spec.topologySpreadConstraints` to enable users control how Pods are spread across the cluster among failure-domains. ([#77327](https://github.com/kubernetes/kubernetes/pull/77327), [#77760](https://github.com/kubernetes/kubernetes/pull/77760), [#77828](https://github.com/kubernetes/kubernetes/pull/77828), [#79062](https://github.com/kubernetes/kubernetes/pull/79062), [#80011](https://github.com/kubernetes/kubernetes/pull/80011), [#81068](https://github.com/kubernetes/kubernetes/pull/81068), [@Huang-Wei](https://github.com/Huang-Wei))
- Pod spread constraints have been added in alpha. You can use these constraints to control how Pods are spread across the cluster among failure-domains. ([#77327](https://github.com/kubernetes/kubernetes/pull/77327), [#77760](https://github.com/kubernetes/kubernetes/pull/77760), [#77828](https://github.com/kubernetes/kubernetes/pull/77828), [#79062](https://github.com/kubernetes/kubernetes/pull/79062), [#80011](https://github.com/kubernetes/kubernetes/pull/80011), [#81068](https://github.com/kubernetes/kubernetes/pull/81068), [@Huang-Wei](https://github.com/Huang-Wei))

Copy link
Copy Markdown
Member

@saschagrunert saschagrunert Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to https://github.com/kubernetes/website/pull/16446/files#r326021937, I've change the note on all relevant PRs, too.

Copy link
Copy Markdown
Member Author

@Huang-Wei Huang-Wei Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert Thanks. I've updated the words to make them consistent.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2019
@xmudrii
Copy link
Copy Markdown
Member

xmudrii commented Sep 19, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from xmudrii September 19, 2019 16:38
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Sep 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, idealhack, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit cdbd404 into kubernetes:master Sep 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 21, 2019
@idealhack idealhack modified the milestones: v1.17, v1.16 Sep 21, 2019
@Huang-Wei Huang-Wei deleted the even-pods-spread branch September 21, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert requested changes

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

+1 more reviewer

@idealhack idealhack idealhack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@idealhack idealhack

@justaugustus justaugustus

@saschagrunert saschagrunert

@lachie83 lachie83

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

7 participants

@Huang-Wei @k8s-ci-robot @saschagrunert @xmudrii @justaugustus @idealhack @lachie83