Build Go 1.21.6 and 1.20.13#3413
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 10, 2024
Merged
Conversation
Signed-off-by: cpanato <ctadeu@gmail.com>
24 tasks
Member
|
/lgtm |
xmudrii
reviewed
Jan 10, 2024
Member
xmudrii
left a comment
There was a problem hiding this comment.
Just a non-blocking nit
/lgtm
/approve
| match: "CONFIG: 'go\\d+.\\d+-bullseye'" | ||
|
|
||
| # Golang (previous release branches: 1.29) | ||
| - name: "golang (previous release branches: 1.28)" |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| - name: "golang (previous release branches: 1.28)" | |
| - name: "golang (previous release branches: 1.29)" |
Member
Author
There was a problem hiding this comment.
will update in a follow up
good catch
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #3412
Does this PR introduce a user-facing change?
/assign @xmudrii @saschagrunert @puerco @jeremyrickard
cc @kubernetes/release-engineering