Skip to content

util-images/watch-list: replace ENABLE_CLIENT_GO_WATCH_LIST_ALPHA env var with KUBE_FEATURE_WatchListClient#2506

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
p0lyn0mial:upstream-watchlist-update-env-var-name
Jan 18, 2024
Merged

util-images/watch-list: replace ENABLE_CLIENT_GO_WATCH_LIST_ALPHA env var with KUBE_FEATURE_WatchListClient#2506
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
p0lyn0mial:upstream-watchlist-update-env-var-name

Conversation

@p0lyn0mial
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial commented Jan 16, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The previous environment variable is being replaced in kubernetes/kubernetes#122791

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@p0lyn0mial
util-images/watch-list: replace ENABLE_CLIENT_GO_WATCH_LIST_ALPHA e…
2f6cc31 
…nv var with `KUBE_FEATURE_WatchListClient`

The previous environment variable is being replaced in kubernetes/kubernetes#122791
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Jan 16, 2024

/hold

until kubernetes/kubernetes#122791 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Jan 16, 2024

/assign @wojtek-t

@p0lyn0mial p0lyn0mial mentioned this pull request Jan 16, 2024
Merged
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jan 16, 2024

with kubernetes/kubernetes#122791, this makes sense to me.

/lgtm

keep the hold until both PRs are ready to merge and then you can coordinate merging them.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Jan 18, 2024

@marseel since Wojtek is out would you mind approving his PR?

@marseel
Copy link
Copy Markdown
Member

marseel commented Jan 18, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, marseel, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Jan 18, 2024

the watch-list perf tests are executed once a day around 10 AM CET. The nearest run is tomorrow morning. There is plenty of time to merge both PRs.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 23828e9 into kubernetes:master Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marseel marseel Awaiting requested review from marseel

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@marseel marseel

@deads2k deads2k

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@p0lyn0mial @deads2k @marseel @k8s-ci-robot @wojtek-t