Skip to content

EventHandler removal and counting#98536

Closed
kevindelgado wants to merge 1 commit intokubernetes:masterfrom
kevindelgado:draft/event-handler-removal-count
Closed

EventHandler removal and counting#98536
kevindelgado wants to merge 1 commit intokubernetes:masterfrom
kevindelgado:draft/event-handler-removal-count

Conversation

@kevindelgado
Copy link
Copy Markdown
Contributor

@kevindelgado kevindelgado commented Jan 28, 2021

This PR was split from #97214

What type of PR is this?

/kind feature

What this PR does / why we need it:
Expands the SharedInformer interface to enable removing event handlers
and retrieving the count of event handlers for an individual informer.

The controller-runtime package uses the SharedInformer directly from client-go (rather than through a factory). It would like the ability to track the number of event handlers registered to a shared informer in order to automatically shut down informers that don't have any event handlers registered to it.

Which issue(s) this PR fixes:

Unblocks work relating to kubernetes-sigs/controller-runtime#1192

Related design doc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2021

@kevindelgado: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2021

Hi @kevindelgado. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 28, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevindelgado
To complete the pull request process, please assign deads2k after the PR has been reviewed.
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevindelgado kevindelgado mentioned this pull request Jan 28, 2021
Closed
@kevindelgado
EventHandler removal and counting
3a73b6e 
Expands the SharedInformer interface to enable removing event handlers
and retrieving the count of event handlers for an individual informer.
@kevindelgado kevindelgado force-pushed the draft/event-handler-removal-count branch from 6a7f21c to 3a73b6e Compare February 1, 2021 22:55
@kevindelgado
Copy link
Copy Markdown
Contributor Author

kevindelgado commented Feb 1, 2021

/assign @DirectXMan12
/assign @yliaog

Feedback from the other PR #97214 has been addressed here.

Please take a look!

@DirectXMan12
Copy link
Copy Markdown
Contributor

DirectXMan12 commented Feb 2, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2021
@kevindelgado
Copy link
Copy Markdown
Contributor Author

kevindelgado commented Feb 2, 2021

/retest

@fedebongio
Copy link
Copy Markdown
Contributor

fedebongio commented Feb 2, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 2, 2021
@kevindelgado
Copy link
Copy Markdown
Contributor Author

kevindelgado commented Feb 6, 2021

Closing as duplicate of #98657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@thockin thockin Awaiting requested review from thockin

Assignees

@DirectXMan12 DirectXMan12

@yliaog yliaog

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kevindelgado @k8s-ci-robot @DirectXMan12 @fedebongio @yliaog