Skip to content

Automated cherry pick of #84654: Drop version from static openapi json file#86970

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
liggitt:automated-cherry-pick-of-#84654-upstream-release-1.17
Jan 9, 2020
Merged

Automated cherry pick of #84654: Drop version from static openapi json file#86970
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
liggitt:automated-cherry-pick-of-#84654-upstream-release-1.17

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Jan 8, 2020 •
edited by justaugustus
Loading

Cherry pick of #84654 on release-1.17.

#84654: Drop version from static openapi json file

For details on the cherry pick process, see the cherry pick requests page.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from davidopp and ixdy January 8, 2020 20:06
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jan 8, 2020

/lgtm
/approve
/kind cleanup
/sig release
/area release-eng
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2020
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Jan 8, 2020

@kubernetes/patch-release-team for approval.
(I'm on the team, but would like another member to apply the label.)

@idealhack idealhack added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 27ff071 into kubernetes:release-1.17 Jan 9, 2020
@liggitt liggitt deleted the automated-cherry-pick-of-#84654-upstream-release-1.17 branch January 13, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@justaugustus justaugustus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

4 participants

@liggitt @justaugustus @k8s-ci-robot @idealhack