Skip to content

Automated cherry pick of #81880: Bumped the number of times a node tries to lookup itself#85663

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
dims:automated-cherry-pick-of-#81880-upstream-release-1.17
Nov 28, 2019
Merged

Automated cherry pick of #81880: Bumped the number of times a node tries to lookup itself#85663
k8s-ci-robot merged 1 commit intokubernetes:release-1.17from
dims:automated-cherry-pick-of-#81880-upstream-release-1.17

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Nov 27, 2019

Cherry pick of #81880 on release-1.17.

#81880: Bumped the number of times a node tries to lookup itself

For details on the cherry pick process, see the cherry pick requests page.

@MikeSpreitzer @dims
Bumped the number of times a node tries to lookup itself
451a053 
Increased the number of tries in pkg/util/node/node.go::GetNodeIP by
1, because the kube-proxy was giving up too early.

This is meant to address kubernetes#81879
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 27, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 27, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 27, 2019

@dims: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

Details

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #81880.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 27, 2019

@dims: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 27, 2019
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 27, 2019

/release-note-none

Cherry pick for #81880

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2019
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 27, 2019

/kind bug
/priority important-soon
/sig network

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 27, 2019
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 27, 2019

/assign @thockin

@dims dims mentioned this pull request Nov 27, 2019
Merged
@dims
Copy link
Copy Markdown
Member Author

dims commented Nov 28, 2019

/assign @smarterclayton @liggitt

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 28, 2019

based on ack of the master PR by thockin

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2019
@justaugustus
Copy link
Copy Markdown
Member

justaugustus commented Nov 28, 2019

Release Managers approval:
/lgtm
/approve

@justaugustus justaugustus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 28, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4caae3c into kubernetes:release-1.17 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@justaugustus justaugustus

@liggitt liggitt

@smarterclayton smarterclayton

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

7 participants

@dims @k8s-ci-robot @liggitt @justaugustus @smarterclayton @thockin @MikeSpreitzer