fix etcd version check error on ARM#85601
Conversation
"etcd -version" command output an additional line on ARM platform: "running etcd on unsupported architecture "arm64" since ETCD_UNSUPPORTED_ARCH is set" Currently etcd version filtering code can not get correct version number. Signed-off-by: Howard Zhang <howard.zhang@arm.com>
|
@zhlhahaha: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @zhlhahaha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @vishh |
|
/ok-to-test |
|
/kind bug |
|
|
||
| # validate installed version is at least equal to minimum | ||
| version=$(etcd --version | tail -n +1 | head -n 1 | cut -d " " -f 3) | ||
| version=$(etcd --version | grep Version | tail -n +1 | head -n 1 | cut -d " " -f 3) |
There was a problem hiding this comment.
@zhlhahaha etcd --version | grep Version | cut -d " " -f 3 should be enough?
There was a problem hiding this comment.
No, it shows results as following:
3.3.10 go1.10.4
alternative script can be
etcd --version | grep "etcd Version" | cut -d " " -f 3
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, zhlhahaha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
"etcd -version" command output an additional line on ARM platform:
"running etcd on unsupported architecture "arm64" since
ETCD_UNSUPPORTED_ARCH is set"
Currently etcd version filtering code can not get correct version
number.
Signed-off-by: Howard Zhang howard.zhang@arm.com
What type of PR is this?
What this PR does / why we need it:
Ensure hack/local-up-cluster.sh can run on arm
Which issue(s) this PR fixes:
#85600
Special notes for your reviewer:
no
Does this PR introduce a user-facing change?:
no
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
no