Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration#85099
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Nov 13, 2019
Merged
Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration#85099k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
3e457d1 to
11416a4
Compare
Member
Author
|
/retest |
11416a4 to
ac6eb7e
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ac6eb7e to
c650f69
Compare
c650f69 to
7d3012f
Compare
Member
Author
|
/sig api-machinery related to #76310 |
This was referenced Nov 12, 2019
ravisantoshgudimetla
approved these changes
Nov 12, 2019
Contributor
ravisantoshgudimetla
left a comment
There was a problem hiding this comment.
Thank you @liggitt for working on this :)
/lgtm
Member
Author
|
/hold for @deads2k ack |
deads2k
reviewed
Nov 13, 2019
| }}, | ||
| }, | ||
| { | ||
| name: "valid v1 config", |
Contributor
|
Since this is logically generic, moving the group makes sense. It does raise some questions about introducing a v2, but sparse versions should work. /lgtm |
Member
|
/retest |
Member
Author
|
the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040 |
|
/retest Review the full test history for this PR. Silence the bot with an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
resourcequota.admission.k8s.io/v1beta1, kind=Configurationtoapiserver.config.k8s.io/v1, kind=ResourceQuotaConfigurationapiserver.config.k8s.iogroup for generic API server configuration was determined after the configuration type was introducedConfigurationsuffix is used consistently for top-level configuration typesDoes this PR introduce a user-facing change?:
/cc @derekwaynecarr @deads2k @ahg-g @ravisantoshgudimetla