Skip to content

Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration#85098

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:admission-config-v1
Nov 13, 2019
Merged

Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration#85098
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
liggitt:admission-config-v1

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Nov 11, 2019 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • This promotes apiserver.config.k8s.io/v1alpha1, kind=AdmissionConfiguration to apiserver.config.k8s.io/v1, kind=AdmissionConfiguration with no schema changes. This was added in v1.6.0 and has been in use with no changes since then.
  • Docs update in Update docs for AdmissionConfiguration v1 website#17548

There are efforts in progress to graduate individual admission configurations (like resourcequota), and those require plumbing information through this config type.

Does this PR introduce a user-facing change?:

kube-apiserver: The `AdmissionConfiguration` type accepted by `--admission-control-config-file` has been promoted to `apiserver.config.k8s.io/v1` with no schema changes.

/sig api-machinery
/cc @deads2k @derekwaynecarr
fyi @ahg-g @ravisantoshgudimetla

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2019
@liggitt liggitt force-pushed the admission-config-v1 branch from 16588b5 to bdf8b0e Compare November 11, 2019 17:11
@k8s-ci-robot k8s-ci-robot added area/apiserver kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2019
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Nov 11, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt liggitt force-pushed the admission-config-v1 branch 2 times, most recently from c55395f to 095d520 Compare November 11, 2019 18:19
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the admission-config-v1 branch from 095d520 to 1234290 Compare November 12, 2019 14:06
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 12, 2019

/priority important-soon

related to #76310

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2019
This was referenced Nov 12, 2019
Merged
Merged
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 12, 2019

/retest

@liggitt liggitt changed the title Promote AdmissionConfiguration type to apiserver.config.k8s.io/v1 Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration Nov 12, 2019
@liggitt liggitt added this to the v1.17 milestone Nov 12, 2019
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

for @deads2k to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2019
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Nov 13, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2019
@ahg-g
Copy link
Copy Markdown
Member

ahg-g commented Nov 13, 2019

/retest

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Nov 13, 2019

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

@ahg-g
Copy link
Copy Markdown
Member

ahg-g commented Nov 13, 2019 •
edited
Loading

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

This was failing since yesterday, more than few PRs get merged since this started to fail, retesting few times actually works.

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 13, 2019

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 1234290 link /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit b49afbf into kubernetes:master Nov 13, 2019
@liggitt liggitt deleted the admission-config-v1 branch November 14, 2019 14:38
@dashpole dashpole mentioned this pull request Mar 6, 2021
Closed
This was referenced Apr 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@deads2k deads2k

@ravisantoshgudimetla ravisantoshgudimetla

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

7 participants

@liggitt @fejta-bot @k8s-ci-robot @deads2k @ahg-g @ravisantoshgudimetla @andrewsykim