Skip to content

Promote PodProcessNamespaceSharing feature to GA#84356

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
verb:pid-ga
Nov 13, 2019
Merged

Promote PodProcessNamespaceSharing feature to GA#84356
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
verb:pid-ga

Conversation

@verb
Copy link
Copy Markdown
Contributor

@verb verb commented Oct 25, 2019 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it: This promotes the PodProcessNamespaceSharing from beta to GA

The Process Namespace Sharing KEP specifies the following criteria for Beta -> GA graduation:

  • 3 articles describing using shareProcessNamespace in a task.
  • shareProcessNamespace referenced in documentation for a Kubernetes cloud
    provider (as proxy indicator for feature enabled on cloud provider).
  • Feature spends at least 2 release in beta.
  • No open bug reports for latest release.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Pod process namespace sharing is now Generally Available. The `PodShareProcessNamespace` feature gate is now deprecated and will be removed in Kubernetes 1.19.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://git.k8s.io/enhancements/keps/sig-node/20190920-pod-pid-namespace.md
- [Usage]: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@verb
Copy link
Copy Markdown
Contributor Author

verb commented Oct 25, 2019

/sig node
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@verb
Copy link
Copy Markdown
Contributor Author

verb commented Oct 25, 2019

/assign @yujuhong

@verb verb mentioned this pull request Oct 25, 2019
Closed
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Oct 25, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@verb verb mentioned this pull request Oct 25, 2019
Merged
liggitt
liggitt reviewed Oct 30, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2019
@verb verb changed the title Promote PodProcessNamespaceSharing feature to GA WIP: Promote PodProcessNamespaceSharing feature to GA Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/kubelet area/test labels Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 31, 2019
@verb
Copy link
Copy Markdown
Contributor Author

verb commented Nov 1, 2019

/retest

@verb verb changed the title WIP: Promote PodProcessNamespaceSharing feature to GA Promote PodProcessNamespaceSharing feature to GA Nov 1, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2019
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 5, 2019

mechanics look good, let me know once this has SIG review/approval

@yujuhong
Copy link
Copy Markdown
Contributor

yujuhong commented Nov 6, 2019

/lgtm
/approve

Adding sig-node leads for approval: @dchen1107 @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@dchen1107
Copy link
Copy Markdown
Member

dchen1107 commented Nov 12, 2019

/lgtm
/approve

@verb
Copy link
Copy Markdown
Contributor Author

verb commented Nov 12, 2019

/assign @liggitt

Hi Jordan, this now has sig-node approval and is ready for 1.17. Thanks!

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 12, 2019

/approve

@verb
Copy link
Copy Markdown
Contributor Author

verb commented Nov 13, 2019

Looks like the approve didn't take. Testing:

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, liggitt, verb, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 13, 2019

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot merged commit c10d29b into kubernetes:master Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@liggitt liggitt

@dchen1107 dchen1107

@yujuhong yujuhong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

6 participants

@verb @fejta-bot @liggitt @yujuhong @dchen1107 @k8s-ci-robot