Skip to content

Add known issue for informer-gen for packages with dots#83023

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:code-gen-dots-known-issue
Sep 23, 2019
Merged

Add known issue for informer-gen for packages with dots#83023
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
nikhita:code-gen-dots-known-issue

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Sep 23, 2019 •
edited
Loading

Issue: #82860
Fix in: #82410

Does this PR introduce a user-facing change?:

NONE

/sig release
/kind documentation
/cc @munnerz @sttts @liggitt
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 23, 2019

@nikhita: GitHub didn't allow me to assign the following users: sgrunert.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

Issue: #82860
Fix: #82410

Does this PR introduce a user-facing change?:

NONE

/sig release
/kind documentation
/cc @munnerz @sttts @liggitt
/assign @liggitt @sgrunert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 23, 2019
@nikhita nikhita mentioned this pull request Sep 23, 2019
Merged
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Sep 23, 2019

/assign @saschagrunert

oops 😬

saschagrunert
saschagrunert approved these changes Sep 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikhita 🙏

/lgtm

I think we have to change this on the website (kubernetes.io) as well. Do you want to take care of that too?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Sep 23, 2019

/retest

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Sep 23, 2019

/approve

liggitt
liggitt reviewed Sep 23, 2019
View reviewed changes
Comment thread CHANGELOG-1.16.md Outdated
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
@nikhita nikhita force-pushed the code-gen-dots-known-issue branch from 08dfd17 to c775d34 Compare September 23, 2019 17:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Sep 23, 2019

I think we have to change this on the website (kubernetes.io) as well. Do you want to take care of that too?

Will do!

@nikhita nikhita mentioned this pull request Sep 23, 2019
Merged
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Sep 23, 2019

I think we have to change this on the website (kubernetes.io) as well. Do you want to take care of that too?

Created kubernetes/website#16523

@saschagrunert
Copy link
Copy Markdown
Member

saschagrunert commented Sep 23, 2019

/lgtm

Thanks again for following up on the website as well!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit ef2016c into kubernetes:master Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@munnerz munnerz Awaiting requested review from munnerz

@sttts sttts Awaiting requested review from sttts

Assignees

@saschagrunert saschagrunert

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.17

Development

Successfully merging this pull request may close these issues.

4 participants

@nikhita @k8s-ci-robot @saschagrunert @liggitt