Skip to content

Skip spec.volumes mount/map test if no SSH#81755

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
wongma7:skip-ssh-volumes
Aug 23, 2019
Merged

Skip spec.volumes mount/map test if no SSH#81755
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
wongma7:skip-ssh-volumes

Conversation

@wongma7

@wongma7 wongma7 commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it: This test requires SSH access but not all clusters will have it.

Which issue(s) this PR fixes:

mitigates #81751

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 21, 2019
@wongma7 wongma7 mentioned this pull request Aug 22, 2019
Closed
@msau42

msau42 commented Aug 22, 2019

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@msau42

msau42 commented Aug 22, 2019

Copy link
Copy Markdown
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 22, 2019
@k8s-ci-robot

k8s-ci-robot commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2019
@msau42 msau42 mentioned this pull request Aug 22, 2019
Merged
@fejta-bot

fejta-bot commented Aug 22, 2019

Copy link
Copy Markdown

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@aojea

aojea commented Aug 23, 2019

Copy link
Copy Markdown
Member

/cc @BenTheElder

@BenTheElder

BenTheElder commented Aug 23, 2019

Copy link
Copy Markdown
Member

Could we start porting these to use the pod + nsenter trick some of the other storage tests use instead?

@k8s-ci-robot k8s-ci-robot merged commit 15812bc into kubernetes:master Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@wongma7

wongma7 commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

@BenTheElder yes, I've left the TODO issue open #81751 .

@BenTheElder

BenTheElder commented Aug 23, 2019

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@verult verult Awaiting requested review from verult

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

6 participants

@wongma7 @msau42 @k8s-ci-robot @fejta-bot @aojea @BenTheElder