Skip to content

Promote PodDisruptionBudget to GA#81571

Closed
mortent wants to merge 3 commits intokubernetes:masterfrom
mortent:PodDisruptionBudgetToGA
Closed

Promote PodDisruptionBudget to GA#81571
mortent wants to merge 3 commits intokubernetes:masterfrom
mortent:PodDisruptionBudgetToGA

Conversation

@mortent
Copy link
Copy Markdown
Member

@mortent mortent commented Aug 18, 2019 •
edited
Loading

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Promotes PodDisruptionBudget type to v1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The `PodDisruptionBudget` API have been promoted to `policy/v1`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 18, 2019
@mortent mortent force-pushed the PodDisruptionBudgetToGA branch 2 times, most recently from e103d71 to c33499b Compare August 19, 2019 00:49
@fedebongio
Copy link
Copy Markdown
Contributor

fedebongio commented Aug 19, 2019

/assign @bsalamat

@fedebongio
Copy link
Copy Markdown
Contributor

fedebongio commented Aug 19, 2019

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 19, 2019
@mortent mortent force-pushed the PodDisruptionBudgetToGA branch from 81c7363 to 3022db9 Compare August 23, 2019 20:23
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 23, 2019
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Aug 24, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from cblecker August 24, 2019 05:06
@mortent mortent force-pushed the PodDisruptionBudgetToGA branch from 3022db9 to 19ddd97 Compare August 25, 2019 22:11
@mortent mortent force-pushed the PodDisruptionBudgetToGA branch from 19ddd97 to 12e2f56 Compare August 26, 2019 03:27
@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 12, 2019

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-e2e-gce-100-performance

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 12, 2019

/test pull-kubernetes-e2e-gce-100-performance

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Nov 12, 2019

The conflicts has been resolved, so this is ready for review.

@markjacksonfishing
Copy link
Copy Markdown

markjacksonfishing commented Nov 13, 2019

@liggitt @lavalamp @mortent 24 hours till code freeze, we still going to make v1.17?

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Nov 14, 2019

This PR is in good shape, but having swept open issues/PRs around PDBs (organized in https://github.com/orgs/kubernetes/projects/36), there still looks to be work needed before we call it GA. Let's coordinate in the linked project board to work through those issues and add test coverage so this can proceed in 1.18.

/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 14, 2019
@mortent mortent mentioned this pull request Dec 4, 2019
Merged
@annajung
Copy link
Copy Markdown

annajung commented Jan 31, 2020

Hello @mortent 👋 I'm one of the Bug Triage shadows for the 1.18 release. Since this PR is tagged for 1.18, I'd like to check its status. Is this PR intended for milestone 1.18?

Friendly reminder: Code freeze is scheduled for March 5th.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2020

@mortent: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020
@annajung
Copy link
Copy Markdown

annajung commented Feb 13, 2020

Hello @mortent @liggitt Checking with you again. Is this PR intended for milestone 1.18?

@annajung
Copy link
Copy Markdown

annajung commented Feb 27, 2020

Hey @mortent @liggitt Code freeze is coming up in a few days and wanted to check in with you to see if this will be completed for the release?

@mortent
Copy link
Copy Markdown
Member Author

mortent commented Feb 27, 2020

@annajung There are still open issues. This will not make it for 1.18.

@annajung
Copy link
Copy Markdown

annajung commented Feb 27, 2020

@mortent Thank you for the update. I will defer the milestone to v.1.19.
/milestone v1.19

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Feb 27, 2020
@liggitt liggitt removed the api-review Categorizes an issue or PR as actively needing an API review. label Mar 10, 2020
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented May 27, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2020
@bai
Copy link
Copy Markdown

bai commented May 29, 2020

👋 Hello from Bug Triage team! This PR has not been updated for a while, so I'd like to check its status. The code freeze is starting June 25th (about 4 weeks from now) and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.19, is it still planned for this release?

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Jun 28, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 28, 2020
@liggitt liggitt removed this from the v1.19 milestone Jul 8, 2020
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Aug 7, 2020

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 7, 2020

@fejta-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seh
Copy link
Copy Markdown
Contributor

seh commented Sep 26, 2020

See #95083 for a matter we could address before graduating.

@mortent mortent mentioned this pull request Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

+1 more reviewer

@lavalamp lavalamp lavalamp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lavalamp lavalamp

@liggitt liggitt

@bsalamat bsalamat

Labels

area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

API Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.