Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API#77448
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom May 11, 2019
Merged
Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API#77448k8s-ci-robot merged 2 commits intokubernetes:masterfrom
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
Contributor
Author
|
@kubernetes/sig-api-machinery-api-reviews |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
All except PartialObjectMetadataList are identical and should be made that way internally. This allows the internalversion to convert between them.
Contributor
|
/assign |
liggitt
reviewed
May 6, 2019
liggitt
reviewed
May 6, 2019
liggitt
reviewed
May 6, 2019
staging/src/k8s.io/apiextensions-apiserver/test/integration/table_test.go
Outdated
Show resolved
Hide resolved
liggitt
reviewed
May 6, 2019
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go
Outdated
Show resolved
Hide resolved
1df1286 to
2d52bed
Compare
Contributor
Author
|
/retest |
Member
|
lgtm. would be good to have tests that accept v1,v1beta1 and v1beta1,v1, and ensure the preferred Content-Type is returned (since we'll switch kubectl to request both shortly, I expect) |
lavalamp
reviewed
May 8, 2019
lavalamp
reviewed
May 8, 2019
lavalamp
reviewed
May 8, 2019
staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go
Outdated
Show resolved
Hide resolved
Contributor
Author
ack |
Now that internal types are equivalent, allow the apiserver to serve metav1 and metav1beta1 depending on the client. Test that in the apiserver integration test and ensure we get the appropriate responses. Register the metav1 type in the appropriate external locations.
Contributor
Author
|
Updated, folded the constant in |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients may now request responses transformed to the v1 form of the Table and PartialObjectMetadata objects. Internally, the metav1 and metav1beta1 types are identical, except for PartialObjectMetadataList in v1beta1 which has a different, legacy protobuf ID ordering (due to a bug not caught until 1.15).
After this change clients can use the v1 version of the objects.
/kind api-change