Adding a new WindowsSecurityOptions struct#77147
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom May 2, 2019
Merged
Adding a new WindowsSecurityOptions struct#77147k8s-ci-robot merged 2 commits intokubernetes:masterfrom
WindowsSecurityOptions struct#77147k8s-ci-robot merged 2 commits intokubernetes:masterfrom
Conversation
As outlined in the KEP at https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190418-windows-security-context.md and improvements on it at kubernetes/enhancements#975 For now this struct is left empty, as discussed in the KEP (see above) and as previously discussed with Jordan Liggitt. It will allow adding GMSA and options as well as `RunAsUserName` options; both of which have already been pre-implemented respectively at kubernetes#75459 and kubernetes#73609; and both of which will need to be re-based to make use of the new struct. Signed-off-by: Jean Rouge <rougej+github@gmail.com>
Contributor
Author
|
/sig api |
Contributor
Author
|
/assign @liggitt |
Contributor
Author
|
/label api-review |
Contributor
Author
|
/test pull-kubernetes-bazel-test |
Member
|
there are custom conversion functions for the PodSecurityContext/SecurityContext structs that aren't actually required, but since we have them adding a new field (like this PR does) requires updating them. I'm dropping the unnecessary custom conversion functions in #77346, which should resolve the unit test failures for this PR |
Member
|
/retest |
Member
|
/priority important-soon |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, wk8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This patch is dding a new
WindowsSecurityOptionsstruct, as outlined in the KEP athttps://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20190418-windows-security-context.md
and improvements on it at
kubernetes/enhancements#975
For now this struct is left empty, as discussed in the KEP (see above) and as
previously discussed with Jordan Liggitt.
It will allow adding GMSA and options as well as
RunAsUserNameoptions; both of which have already been pre-implemented respectively at#75459
and #73609; and both of which
will need to be re-based to make use of the new struct.
Does this PR introduce a user-facing change?: