update apis to ensure that the base64 is needed for []byte by bpfSockOps · Pull Request #75199 · kubernetes/kubernetes

bpfSockOps · 2019-03-08T17:49:23Z

Fixes #72158
What this PR does / why we need it:
Changing API documentation for []byte fields to indicate that it should be base64-encoded when specified in JSON or YAML.
Does this PR introduce a user-facing change?:
NONE

/kind documentation

k8s-ci-robot · 2019-03-08T17:49:24Z

@nzoueidi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-03-08T17:49:30Z

Hi @nzoueidi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2019-03-08T18:01:25Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

yue9944882 · 2019-03-12T10:14:06Z

/ok-to-test
/meow

k8s-ci-robot · 2019-03-12T10:14:07Z

@yue9944882:

Details

In response to this:

/ok-to-test
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bpfSockOps · 2019-03-12T15:00:15Z

Is this related to my changes? It looks for me that they are not.

bpfSockOps · 2019-03-12T19:17:36Z

/restest

yue9944882 · 2019-03-13T03:42:36Z

Please run hack/update-openapi-spec.sh

this pull involves changes in openapi spec, so we need to run the script to sync up resource files in the project

bpfSockOps · 2019-05-24T22:40:29Z

/test pull-kubernetes-verify

bpfSockOps · 2019-05-28T22:54:04Z

/test pull-kubernetes-verify

fejta-bot · 2019-08-27T00:38:44Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-09-26T01:22:53Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2019-10-26T02:07:35Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2019-10-26T02:07:43Z

@fejta-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bpfSockOps · 2019-11-13T14:41:31Z

/reopen
/remove-lifecycle rotten

k8s-ci-robot · 2019-11-13T14:41:33Z

@nzoueidi: Reopened this PR.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-13T14:41:39Z

@nzoueidi: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-13T14:42:00Z

@nzoueidi: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-13T14:43:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nzoueidi
To complete the pull request process, please assign erictune
You can assign the PR to them by writing /assign @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

api/OWNERS
pkg/apis/OWNERS
staging/src/k8s.io/api/OWNERS
staging/src/k8s.io/kube-aggregator/pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bpfSockOps · 2019-11-13T14:43:14Z

/close
Closing it while there is another similar open PR.

k8s-ci-robot · 2019-11-13T14:43:16Z

@nzoueidi: Closed this PR.

Details

In response to this:

/close
Closing it while there is another similar open PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-13T14:53:51Z

@nzoueidi: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu	`2d258cf`	link	`/test pull-kubernetes-e2e-gce-device-plugin-gpu`
pull-kubernetes-bazel-test	`2d258cf`	link	`/test pull-kubernetes-bazel-test`
pull-kubernetes-node-e2e-containerd	`2d258cf`	link	`/test pull-kubernetes-node-e2e-containerd`
pull-kubernetes-node-e2e	`2d258cf`	link	`/test pull-kubernetes-node-e2e`
pull-kubernetes-e2e-kind	`2d258cf`	link	`/test pull-kubernetes-e2e-kind`
pull-kubernetes-verify	`2d258cf`	link	`/test pull-kubernetes-verify`
pull-kubernetes-integration	`2d258cf`	link	`/test pull-kubernetes-integration`
pull-kubernetes-dependencies	`2d258cf`	link	`/test pull-kubernetes-dependencies`
pull-kubernetes-bazel-build	`2d258cf`	link	`/test pull-kubernetes-bazel-build`
pull-kubernetes-e2e-gce	`2d258cf`	link	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-e2e-gce-100-performance	`2d258cf`	link	`/test pull-kubernetes-e2e-gce-100-performance`
pull-kubernetes-typecheck	`2d258cf`	link	`/test pull-kubernetes-typecheck`
pull-kubernetes-kubemark-e2e-gce-big	`2d258cf`	link	`/test pull-kubernetes-kubemark-e2e-gce-big`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2019

k8s-ci-robot requested review from lavalamp and luxas March 8, 2019 17:51

k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 8, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2019

bpfSockOps added 2 commits May 23, 2019 19:44

Fixing apiregistration types.go

0217942

Generate swagger.json

ff82ba7

bpfSockOps added 2 commits May 28, 2019 11:02

Merge branch 'master' of https://github.com/kubernetes/kubernetes

ab96325

Generate scripts of the api

2d258cf

bpfSockOps mentioned this pull request Jun 6, 2019

REQUEST: New membership for nzoueidi kubernetes/org#890

Closed

6 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2019

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 26, 2019

liggitt mentioned this pull request Oct 4, 2019

api/admissionregistration: fix godoc for webhook caBundle #83470

Closed

k8s-ci-robot closed this Oct 26, 2019

k8s-ci-robot reopened this Nov 13, 2019

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 13, 2019

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Nov 13, 2019

k8s-ci-robot closed this Nov 13, 2019

wallrj mentioned this pull request Dec 21, 2022

Add CABundle for ACME Servers cert-manager/cert-manager#5644

Merged

Conversation

bpfSockOps commented Mar 8, 2019

Uh oh!

k8s-ci-robot commented Mar 8, 2019

Uh oh!

k8s-ci-robot commented Mar 8, 2019

Uh oh!

fejta-bot commented Mar 8, 2019

Uh oh!

yue9944882 commented Mar 12, 2019

Uh oh!

k8s-ci-robot commented Mar 12, 2019

Uh oh!

bpfSockOps commented Mar 12, 2019

Uh oh!

bpfSockOps commented Mar 12, 2019

Uh oh!

yue9944882 commented Mar 13, 2019

Uh oh!

bpfSockOps commented May 24, 2019

Uh oh!

bpfSockOps commented May 28, 2019

Uh oh!

fejta-bot commented Aug 27, 2019

Uh oh!

fejta-bot commented Sep 26, 2019

Uh oh!

fejta-bot commented Oct 26, 2019

Uh oh!

k8s-ci-robot commented Oct 26, 2019

Uh oh!

bpfSockOps commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

bpfSockOps commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

k8s-ci-robot commented Nov 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants