Skip to content

Adding detail of how to check the OS version#74174

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:issue_template
Feb 20, 2019
Merged

Adding detail of how to check the OS version#74174
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:issue_template

Conversation

@truongnh1992
Copy link
Copy Markdown
Member

@truongnh1992 truongnh1992 commented Feb 17, 2019

Use command cat /etc/os-release to check the version of OS.

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Describe the detail of the way to check the OS version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Adding detail of how to check the OS version
62fb977 
Use command `cat /etc/os-release` to check the version of OS.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 17, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 17, 2019

Hi @truongnh1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2019
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 17, 2019

/assign @Phillels

nikhita
nikhita approved these changes Feb 18, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@truongnh1992 Thanks for making it clear! :)

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2019
@nikhita
Copy link
Copy Markdown
Member

nikhita commented Feb 18, 2019

/assign @cblecker
for approval

@cblecker
Copy link
Copy Markdown
Member

cblecker commented Feb 20, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 780805a into kubernetes:master Feb 20, 2019
@truongnh1992 truongnh1992 mentioned this pull request Oct 17, 2019
Closed
6 tasks
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikhita nikhita nikhita approved these changes

@castrojo castrojo Awaiting requested review from castrojo

Assignees

@cblecker cblecker

@Phillels Phillels

@nikhita nikhita

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@truongnh1992 @k8s-ci-robot @nikhita @cblecker @Phillels