Skip to content

Correct typecheck contact info#74121

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:edit-owner-contact
Feb 16, 2019
Merged

Correct typecheck contact info#74121
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:edit-owner-contact

Conversation

@truongnh1992
Copy link
Copy Markdown
Member

@truongnh1992 truongnh1992 commented Feb 15, 2019 •
edited
Loading

Small modification of how to contact @rmmh

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2019

Hi @truongnh1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 15, 2019

/assign @rmmh

@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 15, 2019

/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 15, 2019
@danielqsj
Copy link
Copy Markdown
Contributor

danielqsj commented Feb 15, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2019
@danielqsj
Copy link
Copy Markdown
Contributor

danielqsj commented Feb 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 15, 2019

/retest

1 similar comment
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 15, 2019

/retest

cblecker
cblecker requested changes Feb 15, 2019
View reviewed changes
Correct owner's contact
4c18fbc 
@rmmh was no longer involved in the project anymore.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2019
@cblecker cblecker changed the title Correct owner's contact Correct typecheck contact info Feb 16, 2019
@cblecker
Copy link
Copy Markdown
Member

cblecker commented Feb 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 16, 2019

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 528cf14 into kubernetes:master Feb 16, 2019
@truongnh1992 truongnh1992 deleted the edit-owner-contact branch February 17, 2019 17:10
@truongnh1992 truongnh1992 mentioned this pull request Oct 17, 2019
Closed
6 tasks
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker cblecker approved these changes

@rmmh rmmh Awaiting requested review from rmmh

Assignees

@rmmh rmmh

@cblecker cblecker

@danielqsj danielqsj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@truongnh1992 @k8s-ci-robot @danielqsj @cblecker @rmmh