Skip to content

Adding '/usr/bin/env bash'#74107

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:adding-shebang
Feb 18, 2019
Merged

Adding '/usr/bin/env bash'#74107
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
truongnh1992:adding-shebang

Conversation

@truongnh1992
Copy link
Copy Markdown
Member

@truongnh1992 truongnh1992 commented Feb 15, 2019 •
edited
Loading

This commit aims to add '/usr/bin/env bash' as a shebang line
to indicates scripts use bash shell for interpreting.

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2019

Hi @truongnh1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2019
Adding '/usr/bin/env bash'
848da13 
This commit aims to add '/usr/bin/env bash' as a shebang line
to indicates scripts use bash shell for interpreting.

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 15, 2019

/assign @dims

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 15, 2019
@dims
Copy link
Copy Markdown
Member

dims commented Feb 15, 2019

/ok-to-test

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 15, 2019
BenTheElder
BenTheElder approved these changes Feb 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019
@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Feb 15, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 15, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 17, 2019

/retest

@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 17, 2019

/lgtm
/approve

I wonder why the PR doesn't get approve label after you commented /approve?

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Feb 18, 2019

@truongnh1992 the comment above #74107 (comment) explains, I'm a reviewer in those directories but not an approver currently.

/assign @dims

@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 18, 2019

@truongnh1992 the comment above #74107 (comment) explains, I'm a reviewer in those directories but not an approver currently.

/assign @dims

Thank you. I got it.

@dims
Copy link
Copy Markdown
Member

dims commented Feb 18, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@truongnh1992
Copy link
Copy Markdown
Member Author

truongnh1992 commented Feb 18, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 92e0c23 into kubernetes:master Feb 18, 2019
@truongnh1992 truongnh1992 mentioned this pull request Oct 17, 2019
Closed
6 tasks
@truongnh1992 truongnh1992 mentioned this pull request Dec 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@jbeda jbeda Awaiting requested review from jbeda

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@BenTheElder BenTheElder

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@truongnh1992 @k8s-ci-robot @dims @BenTheElder